Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2011-08-24 14:07, Avi Kivity wrote:
> Newer gcc complains that base and size may be used uninitialized, even though
> it is clearly a false warning.

Mmh, gcc is getting dumber again.

>  Silence the warning by indicating to gcc that
> the code path triggering the warning cannot happen.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  hw/vga.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/vga.c b/hw/vga.c
> index 851fd68..b74e6e8 100644
> --- a/hw/vga.c
> +++ b/hw/vga.c
> @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s)
>              base = 0xb8000;
>              size = 0x8000;
>              break;
> +        default:
> +            abort();
>          }
>          region = g_malloc(sizeof(*region));
>          memory_region_init_alias(region, "vga.chain4", &s->vram, offset, size);

...or just make the last case default?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux