From: Timur Tabi <timur@freescale.com>
To: Greg KH <greg@kroah.com>
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig
Date: Thu, 25 Aug 2011 13:02:01 -0500 [thread overview]
Message-ID: <4E568E19.405@freescale.com> (raw)
In-Reply-To: <20110825163234.GA31629@kroah.com>
Greg KH wrote:
> tested doesn't mean that it shouldn't still build properly for other
> platforms, right?
The problem is the dependency on MSR_GS, which is defined only for Book-E
PowerPC chips, not all PowerPC.
So I gave it some more thought, and technically ePAPR extends beyond Book-E, so
it's wrong for the driver to depend on anything specific to Book-E. I've
removed the code that breaks:
/* Check if we're running as a guest of a hypervisor */
if (!(mfmsr() & MSR_GS))
return;
> What is keeping the driver from building on all PPC, or even all arches
> today?
I've made a few changes, and it builds on all PPC now. I'll post a new patch.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Greg KH <greg@kroah.com>
Cc: <sfr@canb.auug.org.au>, <linux-next@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig
Date: Thu, 25 Aug 2011 13:02:01 -0500 [thread overview]
Message-ID: <4E568E19.405@freescale.com> (raw)
In-Reply-To: <20110825163234.GA31629@kroah.com>
Greg KH wrote:
> tested doesn't mean that it shouldn't still build properly for other
> platforms, right?
The problem is the dependency on MSR_GS, which is defined only for Book-E
PowerPC chips, not all PowerPC.
So I gave it some more thought, and technically ePAPR extends beyond Book-E, so
it's wrong for the driver to depend on anything specific to Book-E. I've
removed the code that breaks:
/* Check if we're running as a guest of a hypervisor */
if (!(mfmsr() & MSR_GS))
return;
> What is keeping the driver from building on all PPC, or even all arches
> today?
I've made a few changes, and it builds on all PPC now. I'll post a new patch.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-08-25 18:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 16:20 [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig Timur Tabi
2011-08-25 16:20 ` Timur Tabi
2011-08-25 16:32 ` Greg KH
2011-08-25 18:02 ` Timur Tabi [this message]
2011-08-25 18:02 ` Timur Tabi
2011-08-25 18:46 ` Greg KH
2011-08-25 18:51 ` Timur Tabi
2011-08-25 18:51 ` Timur Tabi
2011-08-25 19:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E568E19.405@freescale.com \
--to=timur@freescale.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.