From: Andreas Oberritter <obi@linuxtv.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: dvb_frontend.c warning: can 'timeout' be removed?
Date: Fri, 26 Aug 2011 12:17:36 +0200 [thread overview]
Message-ID: <4E5772C0.6020004@linuxtv.org> (raw)
In-Reply-To: <201108251529.18402.hverkuil@xs4all.nl>
Hello Hans,
On 25.08.2011 15:29, Hans Verkuil wrote:
> This is the warning the daily build gives:
>
> v4l-dvb-git/drivers/media/dvb/dvb-core/dvb_frontend.c: In function 'dvb_frontend_thread':
> v4l-dvb-git/drivers/media/dvb/dvb-core/dvb_frontend.c:540:16: warning: variable 'timeout' set but not used [-Wunused-but-set-variable]
>
> The 'timeout' variable is indeed not used, but should it? I'm not familiar enough
> with this code to decide.
you can safely remove this variable. The code always behaves the same
way, be it woken up by a timeout or on demand (unless freezing or
stopping the thread).
Regards,
Andreas
prev parent reply other threads:[~2011-08-26 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 13:29 dvb_frontend.c warning: can 'timeout' be removed? Hans Verkuil
2011-08-26 10:17 ` Andreas Oberritter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5772C0.6020004@linuxtv.org \
--to=obi@linuxtv.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.