* dvb_frontend.c warning: can 'timeout' be removed?
@ 2011-08-25 13:29 Hans Verkuil
2011-08-26 10:17 ` Andreas Oberritter
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2011-08-25 13:29 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media
This is the warning the daily build gives:
v4l-dvb-git/drivers/media/dvb/dvb-core/dvb_frontend.c: In function 'dvb_frontend_thread':
v4l-dvb-git/drivers/media/dvb/dvb-core/dvb_frontend.c:540:16: warning: variable 'timeout' set but not used [-Wunused-but-set-variable]
The 'timeout' variable is indeed not used, but should it? I'm not familiar enough
with this code to decide.
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dvb_frontend.c warning: can 'timeout' be removed?
2011-08-25 13:29 dvb_frontend.c warning: can 'timeout' be removed? Hans Verkuil
@ 2011-08-26 10:17 ` Andreas Oberritter
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Oberritter @ 2011-08-26 10:17 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Mauro Carvalho Chehab, linux-media
Hello Hans,
On 25.08.2011 15:29, Hans Verkuil wrote:
> This is the warning the daily build gives:
>
> v4l-dvb-git/drivers/media/dvb/dvb-core/dvb_frontend.c: In function 'dvb_frontend_thread':
> v4l-dvb-git/drivers/media/dvb/dvb-core/dvb_frontend.c:540:16: warning: variable 'timeout' set but not used [-Wunused-but-set-variable]
>
> The 'timeout' variable is indeed not used, but should it? I'm not familiar enough
> with this code to decide.
you can safely remove this variable. The code always behaves the same
way, be it woken up by a timeout or on demand (unless freezing or
stopping the thread).
Regards,
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-26 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-25 13:29 dvb_frontend.c warning: can 'timeout' be removed? Hans Verkuil
2011-08-26 10:17 ` Andreas Oberritter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.