[PATCH] iio: accel: ADIS16209: Fix double registration of in_incli0_index

[PATCH] iio: accel: ADIS16209: Fix double registration of in_incli0_index

[michael.hennerich]

From: Michael Hennerich <michael.hennerich@analog.com>

iio (null): tried to double register : in_incli0_index

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
---
 drivers/staging/iio/accel/adis16209_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16209_core.c b/drivers/staging/iio/accel/adis16209_core.c
index 183b5c2..8d5f1d5 100644
--- a/drivers/staging/iio/accel/adis16209_core.c
+++ b/drivers/staging/iio/accel/adis16209_core.c
@@ -431,11 +431,11 @@ static struct iio_chan_spec adis16209_channels[] = {
 		 (1 << IIO_CHAN_INFO_SCALE_SEPARATE),
 		 in_aux, ADIS16209_SCAN_AUX_ADC,
 		 IIO_ST('u', 12, 16, 0), 0),
-	IIO_CHAN(IIO_INCLI, 0, 1, 0, NULL, 0, IIO_MOD_X,
+	IIO_CHAN(IIO_INCLI, 1, 0, 0, NULL, 0, IIO_MOD_X,
 		 (1 << IIO_CHAN_INFO_SCALE_SHARED),
 		 incli_x, ADIS16209_SCAN_INCLI_X,
 		 IIO_ST('s', 14, 16, 0), 0),
-	IIO_CHAN(IIO_INCLI, 0, 1, 0, NULL, 0, IIO_MOD_Y,
+	IIO_CHAN(IIO_INCLI, 1, 0, 0, NULL, 0, IIO_MOD_Y,
 		 (1 << IIO_CHAN_INFO_SCALE_SHARED),
 		 incli_y, ADIS16209_SCAN_INCLI_Y,
 		 IIO_ST('s', 14, 16, 0), 0),
-- 
1.7.0.4

Re: [PATCH] iio: accel: ADIS16209: Fix double registration of in_incli0_index

[Jonathan Cameron]

On 08/26/11 12:36, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> 
> iio (null): tried to double register : in_incli0_index
oops.  That (null) is clearly an issue to.

As for the fix.  Yet another bug due to that pesky IIO_CHAN
macro. hohum.

Thanks and merged.
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
>  drivers/staging/iio/accel/adis16209_core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16209_core.c b/drivers/staging/iio/accel/adis16209_core.c
> index 183b5c2..8d5f1d5 100644
> --- a/drivers/staging/iio/accel/adis16209_core.c
> +++ b/drivers/staging/iio/accel/adis16209_core.c
> @@ -431,11 +431,11 @@ static struct iio_chan_spec adis16209_channels[] = {
>  		 (1 << IIO_CHAN_INFO_SCALE_SEPARATE),
>  		 in_aux, ADIS16209_SCAN_AUX_ADC,
>  		 IIO_ST('u', 12, 16, 0), 0),
> -	IIO_CHAN(IIO_INCLI, 0, 1, 0, NULL, 0, IIO_MOD_X,
> +	IIO_CHAN(IIO_INCLI, 1, 0, 0, NULL, 0, IIO_MOD_X,
>  		 (1 << IIO_CHAN_INFO_SCALE_SHARED),
>  		 incli_x, ADIS16209_SCAN_INCLI_X,
>  		 IIO_ST('s', 14, 16, 0), 0),
> -	IIO_CHAN(IIO_INCLI, 0, 1, 0, NULL, 0, IIO_MOD_Y,
> +	IIO_CHAN(IIO_INCLI, 1, 0, 0, NULL, 0, IIO_MOD_Y,
>  		 (1 << IIO_CHAN_INFO_SCALE_SHARED),
>  		 incli_y, ADIS16209_SCAN_INCLI_Y,
>  		 IIO_ST('s', 14, 16, 0), 0),

RE: [PATCH] iio: accel: ADIS16209: Fix double registration of in_incli0_index

[Hennerich, Michael]

Jonathan Cameron wrote on 2011-08-26:
> On 08/26/11 12:36, michael.hennerich@analog.com wrote:
>> From: Michael Hennerich <michael.hennerich@analog.com>
>>
>> iio (null): tried to double register : in_incli0_index
> oops.  That (null) is clearly an issue to.
>
> As for the fix.  Yet another bug due to that pesky IIO_CHAN
> macro. hohum.
>
> Thanks and merged.

I'm currently in progress testing some devices, since I need to update our documentation.
Will send more patches - would be great if you could take them through your tree.


Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif

Re: [PATCH] iio: accel: ADIS16209: Fix double registration of in_incli0_index

[Jonathan Cameron]

On 08/26/11 12:56, Hennerich, Michael wrote:
> Jonathan Cameron wrote on 2011-08-26:
>> On 08/26/11 12:36, michael.hennerich@analog.com wrote:
>>> From: Michael Hennerich <michael.hennerich@analog.com>
>>>
>>> iio (null): tried to double register : in_incli0_index
>> oops.  That (null) is clearly an issue to.
>>
>> As for the fix.  Yet another bug due to that pesky IIO_CHAN
>> macro. hohum.
>>
>> Thanks and merged.
> 
> I'm currently in progress testing some devices, since I need to update our documentation.
> Will send more patches - would be great if you could take them through your tree.
Will do and thanks for all the testing.

Jonathan