From: Clemens Ladisch <clemens@ladisch.de>
To: Felipe Balbi <balbi@ti.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: usb: mixer: increase control transfer timeout
Date: Mon, 29 Aug 2011 13:58:31 +0200 [thread overview]
Message-ID: <4E5B7EE7.6070103@ladisch.de> (raw)
In-Reply-To: <1314616226-15942-1-git-send-email-balbi@ti.com>
Felipe Balbi wrote:
> 100ms might not be enough for slower devices. Increasing
> timeout to 1000ms doesn't seem like overkill.
>
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -296,7 +296,7 @@ static int get_ctl_value_v1(struct usb_mixer_elem_info *cval, int request, int v
> if (snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0), request,
> USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN,
> validx, snd_usb_ctrl_intf(chip) | (cval->id << 8),
> - buf, val_len, 100) >= val_len) {
> + buf, val_len, 1000) >= val_len) {
If the timeout for reading values needs to be increased, writing (in
snd_usb_mixer_set_ctl_value) probably needs some attention too.
Regards,
Clemens
WARNING: multiple messages have this Message-ID (diff)
From: Clemens Ladisch <clemens@ladisch.de>
To: Felipe Balbi <balbi@ti.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] sound: usb: mixer: increase control transfer timeout
Date: Mon, 29 Aug 2011 13:58:31 +0200 [thread overview]
Message-ID: <4E5B7EE7.6070103@ladisch.de> (raw)
In-Reply-To: <1314616226-15942-1-git-send-email-balbi@ti.com>
Felipe Balbi wrote:
> 100ms might not be enough for slower devices. Increasing
> timeout to 1000ms doesn't seem like overkill.
>
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -296,7 +296,7 @@ static int get_ctl_value_v1(struct usb_mixer_elem_info *cval, int request, int v
> if (snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0), request,
> USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN,
> validx, snd_usb_ctrl_intf(chip) | (cval->id << 8),
> - buf, val_len, 100) >= val_len) {
> + buf, val_len, 1000) >= val_len) {
If the timeout for reading values needs to be increased, writing (in
snd_usb_mixer_set_ctl_value) probably needs some attention too.
Regards,
Clemens
next prev parent reply other threads:[~2011-08-29 11:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 11:10 [PATCH] sound: usb: mixer: increase control transfer timeout Felipe Balbi
2011-08-29 11:10 ` Felipe Balbi
[not found] ` <1314616226-15942-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2011-08-29 11:16 ` Sebastian Andrzej Siewior
2011-08-29 11:16 ` Sebastian Andrzej Siewior
[not found] ` <20110829111607.GB21556-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2011-08-29 11:19 ` Felipe Balbi
2011-08-29 11:19 ` Felipe Balbi
2011-08-29 11:58 ` Clemens Ladisch [this message]
2011-08-29 11:58 ` Clemens Ladisch
[not found] ` <4E5B7EE7.6070103-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2011-08-29 12:23 ` Felipe Balbi
2011-08-29 12:23 ` Felipe Balbi
2011-08-29 12:31 ` [PATCH v2] " Felipe Balbi
2011-08-29 12:37 ` Jassi Brar
2011-08-29 12:37 ` Jassi Brar
[not found] ` <CABb+yY15qrszsbJSGGFra7mrVRO_oQPUhNT=U7TNpyoYikABPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-29 13:00 ` Felipe Balbi
2011-08-29 13:00 ` Felipe Balbi
2011-08-29 13:34 ` Jassi Brar
2011-08-29 13:34 ` Jassi Brar
2011-08-29 14:05 ` Clemens Ladisch
2011-08-29 14:05 ` Clemens Ladisch
[not found] ` <4E5B9CB0.4090708-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2011-08-29 14:22 ` Jassi Brar
2011-08-29 14:22 ` Jassi Brar
2011-09-12 10:57 ` Takashi Iwai
2011-09-12 10:57 ` Takashi Iwai
2011-09-16 6:25 ` [PATCH] " Takashi Iwai
2011-09-16 6:25 ` Takashi Iwai
2011-09-26 8:49 ` Felipe Balbi
2011-09-27 6:52 ` Clemens Ladisch
2011-09-27 6:52 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5B7EE7.6070103@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.