From: Scott Wood <scottwood@freescale.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Yoder Stuart-B08248 <B08248@freescale.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Wood Scott-B07421 <B07421@freescale.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Joerg.Roedel@amd.com" <Joerg.Roedel@amd.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>, "avi@redhat.com" <avi@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] RFC: vfio / device assignment -- layout of device fd files
Date: Mon, 29 Aug 2011 14:32:29 -0500 [thread overview]
Message-ID: <4E5BE94D.20900@freescale.com> (raw)
In-Reply-To: <4E5BE2A5.7040201@codemonkey.ws>
On 08/29/2011 02:04 PM, Anthony Liguori wrote:
> On 08/29/2011 11:51 AM, Yoder Stuart-B08248 wrote:
>> Instead of config space fixed at 0xf, we would propose
>> a header and multiple 'device info' records at offset 0x0 that would
>> encode everything that user space needs to know about
>> the device:
>
> Why not just use an ioctl with a proper struct?
This is more extensible than a struct -- both in features, and in the
number of each type of resource that you can have, length of strings you
can have, etc.
> The config space is weird for PCI access because it's mirroring a well
> known binary blob. It's not something to replicate if you're inventing
> something new.
There's no intent to replicate config space in general -- config space
is provided as-is. There's little overlap between config space and the
extra information provided. Length can be had from config space, but
only by modifying it. Physical address sort-of overlaps, though bus
addresess could be different from CPU physical addresses[1]. In both
cases, it'd be nice to stay consistent with device-tree regions.
"BAR type" is overlap, but doesn't seem too unreasonable to me.
-Scott
[1] The user is probably less likely to care about the physical address
at all in the PCI case, but consistency is nice.
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Joerg.Roedel@amd.com" <Joerg.Roedel@amd.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
Yoder Stuart-B08248 <B08248@freescale.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"avi@redhat.com" <avi@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] RFC: vfio / device assignment -- layout of device fd files
Date: Mon, 29 Aug 2011 14:32:29 -0500 [thread overview]
Message-ID: <4E5BE94D.20900@freescale.com> (raw)
In-Reply-To: <4E5BE2A5.7040201@codemonkey.ws>
On 08/29/2011 02:04 PM, Anthony Liguori wrote:
> On 08/29/2011 11:51 AM, Yoder Stuart-B08248 wrote:
>> Instead of config space fixed at 0xf, we would propose
>> a header and multiple 'device info' records at offset 0x0 that would
>> encode everything that user space needs to know about
>> the device:
>
> Why not just use an ioctl with a proper struct?
This is more extensible than a struct -- both in features, and in the
number of each type of resource that you can have, length of strings you
can have, etc.
> The config space is weird for PCI access because it's mirroring a well
> known binary blob. It's not something to replicate if you're inventing
> something new.
There's no intent to replicate config space in general -- config space
is provided as-is. There's little overlap between config space and the
extra information provided. Length can be had from config space, but
only by modifying it. Physical address sort-of overlaps, though bus
addresess could be different from CPU physical addresses[1]. In both
cases, it'd be nice to stay consistent with device-tree regions.
"BAR type" is overlap, but doesn't seem too unreasonable to me.
-Scott
[1] The user is probably less likely to care about the physical address
at all in the PCI case, but consistency is nice.
next prev parent reply other threads:[~2011-08-29 19:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 16:51 RFC: vfio / device assignment -- layout of device fd files Yoder Stuart-B08248
2011-08-29 16:51 ` [Qemu-devel] " Yoder Stuart-B08248
2011-08-29 19:04 ` Anthony Liguori
2011-08-29 19:04 ` Anthony Liguori
2011-08-29 19:32 ` Scott Wood [this message]
2011-08-29 19:32 ` Scott Wood
2011-08-29 19:51 ` Alex Williamson
2011-08-29 19:51 ` [Qemu-devel] " Alex Williamson
2011-08-29 21:58 ` Scott Wood
2011-08-29 21:58 ` [Qemu-devel] " Scott Wood
2011-08-29 22:46 ` Alex Williamson
2011-08-29 22:46 ` [Qemu-devel] " Alex Williamson
2011-08-29 23:14 ` Scott Wood
2011-08-29 23:14 ` [Qemu-devel] " Scott Wood
2011-08-30 4:55 ` Alex Williamson
2011-08-30 4:55 ` [Qemu-devel] " Alex Williamson
2011-08-30 16:54 ` Scott Wood
2011-08-30 16:54 ` [Qemu-devel] " Scott Wood
2011-09-01 20:00 ` Michael S. Tsirkin
2011-09-01 20:00 ` [Qemu-devel] " Michael S. Tsirkin
2011-09-01 20:26 ` Scott Wood
2011-09-01 20:26 ` [Qemu-devel] " Scott Wood
2011-09-02 15:57 ` Michael S. Tsirkin
2011-09-02 15:57 ` [Qemu-devel] " Michael S. Tsirkin
2011-09-02 17:50 ` Scott Wood
2011-09-02 17:50 ` [Qemu-devel] " Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5BE94D.20900@freescale.com \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=B08248@freescale.com \
--cc=Joerg.Roedel@amd.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.