All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Jeff Layton <jlayton@poochiereds.net>,
	"J. Bruce Fields" <bfields@redhat.com>,
	Trond Myklebust <Trond.Myklebust@netapp.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSD: Add a cache for fs_locations information
Date: Tue, 30 Aug 2011 13:24:11 -0700	[thread overview]
Message-ID: <4E5D46EB.7030102@panasas.com> (raw)
In-Reply-To: <852F14A9-7826-47A0-BCD6-D5D46E38A39C@oracle.com>

On 08/30/2011 01:00 PM, Chuck Lever wrote:
<>
>> 
>> Won't the above check be rather expensive? You'll need to do a 
>> getxattr call on almost every path component of every lookup,
>> right?
>> 
>> I may be misremembering your talk from connectathon, but I thought
>> you were planning to use a well-known mode for junctions that would
>> cut down on the number of unnecessary getxattrs...
> 
> Yes, that's the plan.  To reduce overhead, the S_ISVTX bit must be
> set before NFSD does the expensive xattr test.  

from: stat(2) - Linux man page

The 'sticky' bit (S_ISVTX) on a directory means that a file in that
directory can be renamed or deleted only by the owner of the file, 
by the owner of the directory, and by a privileged process.

Please explain how does it work? Once the junction is followed and
mounted then the mode-bits get changed to the destination directory's
mode bits? So the Server's junction mode-bits are never exposed, except
in a local-fs file access on the server?

Thanks
Boaz

> However, I don't
> think this kind of filtering was ever implemented.  I got the patch
> from here:
> 
> http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=shortlog;h=refs/heads/fedfs-for-2.6.34
>
>  and that doesn't seem to have it either.  I can implement something
> and repost these.
> 

  reply	other threads:[~2011-08-30 20:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 18:51 [PATCH] NFSD: Add a cache for fs_locations information Chuck Lever
2011-08-30 19:18 ` Jeff Layton
2011-08-30 20:00   ` Chuck Lever
2011-08-30 20:24     ` Boaz Harrosh [this message]
2011-08-30 20:34       ` Trond Myklebust
2011-08-30 21:02         ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5D46EB.7030102@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bfields@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.