From: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: Alexey Khoroshilov <khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
Cc: Steve Wise <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ldv-project-ufN2psIa012HXe+LvDLADg@public.gmane.org
Subject: Re: [PATCH] RDMA/cxgb4: remove accidentally left mutex_unlock(&dev_mutex)
Date: Wed, 31 Aug 2011 15:46:13 -0500 [thread overview]
Message-ID: <4E5E9D95.2050601@opengridcomputing.com> (raw)
In-Reply-To: <1314823410-12621-1-git-send-email-khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
On 08/31/2011 03:43 PM, Alexey Khoroshilov wrote:
> The patch "RDMA/cxgb4: EEH errors can hang the driver" removes
> mutex lock/unlock from c4iw_alloc() except for error path.
> This patch removes the remained mutex_unlock(&dev_mutex).
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov<khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
> ---
> drivers/infiniband/hw/cxgb4/device.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 40a13cc..35896ff 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -414,7 +414,6 @@ static struct c4iw_dev *c4iw_alloc(const struct cxgb4_lld_info *infop)
>
> ret = c4iw_rdev_open(&devp->rdev);
> if (ret) {
> - mutex_unlock(&dev_mutex);
> printk(KERN_ERR MOD "Unable to open CXIO rdev err %d\n", ret);
> ib_dealloc_device(&devp->ibdev);
> return ERR_PTR(ret);
This is actually included in my previously submitted patch:
https://patchwork.kernel.org/patch/1026942/
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Steve Wise <swise@opengridcomputing.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Steve Wise <swise@chelsio.com>, Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@ispras.ru
Subject: Re: [PATCH] RDMA/cxgb4: remove accidentally left mutex_unlock(&dev_mutex)
Date: Wed, 31 Aug 2011 15:46:13 -0500 [thread overview]
Message-ID: <4E5E9D95.2050601@opengridcomputing.com> (raw)
In-Reply-To: <1314823410-12621-1-git-send-email-khoroshilov@ispras.ru>
On 08/31/2011 03:43 PM, Alexey Khoroshilov wrote:
> The patch "RDMA/cxgb4: EEH errors can hang the driver" removes
> mutex lock/unlock from c4iw_alloc() except for error path.
> This patch removes the remained mutex_unlock(&dev_mutex).
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov<khoroshilov@ispras.ru>
> ---
> drivers/infiniband/hw/cxgb4/device.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 40a13cc..35896ff 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -414,7 +414,6 @@ static struct c4iw_dev *c4iw_alloc(const struct cxgb4_lld_info *infop)
>
> ret = c4iw_rdev_open(&devp->rdev);
> if (ret) {
> - mutex_unlock(&dev_mutex);
> printk(KERN_ERR MOD "Unable to open CXIO rdev err %d\n", ret);
> ib_dealloc_device(&devp->ibdev);
> return ERR_PTR(ret);
This is actually included in my previously submitted patch:
https://patchwork.kernel.org/patch/1026942/
Steve.
next prev parent reply other threads:[~2011-08-31 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 20:43 [PATCH] RDMA/cxgb4: remove accidentally left mutex_unlock(&dev_mutex) Alexey Khoroshilov
[not found] ` <1314823410-12621-1-git-send-email-khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
2011-08-31 20:46 ` Steve Wise [this message]
2011-08-31 20:46 ` Steve Wise
2011-08-31 21:01 ` Alexey Khoroshilov
2011-08-31 21:01 ` Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5E9D95.2050601@opengridcomputing.com \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org \
--cc=ldv-project-ufN2psIa012HXe+LvDLADg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.