Re: [PATCH] multipath: systemd unit file

[Hannes Reinecke <hare@suse.de>]

On 09/01/2011 05:00 AM, Benjamin Marzinski wrote:
> Here is a systemd unit file for managing multipathd.
>
[ .. ]
> Index: multipath-tools-110831/multipathd/multipathd.service
> ===================================================================
> --- /dev/null
> +++ multipath-tools-110831/multipathd/multipathd.service
> @@ -0,0 +1,14 @@
> +[Unit]
> +Description=Device-Mapper Multipath Device Controller
> +Before=iscsi.service iscsid.service
> +After=syslog.target
> +
> +[Service]
> +Type=forking
> +PIDFile=/var/run/multipathd.pid
> +ExecStart=/sbin/multipathd
> +ExecReload=/bin/kill -HUP $MAINPID
> +#ExecStop=/path/to/scrip delete-me if not necessary
> +
> +[Install]
> +WantedBy=multi-user.target
>
Hmm. First of all, I'm trying to get rid of the PID file, as with it 
it's quite hard to start multipathing when /var/run isn't mounted.
Plus it's not actually needed; everything can be done via multipathd 
-k nowadays.

So may I suggest to use
ExecReload=/sbin/multipathd -k'reconfigure'

here?
And do we actually need
PIDFile=
for systemd?
If not I'd rather remove that line, too.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)