All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] hw: Add test device for unittests execution v2
Date: Thu, 01 Sep 2011 09:22:39 +0200	[thread overview]
Message-ID: <4E5F32BF.4070801@web.de> (raw)
In-Reply-To: <1314824769-27740-1-git-send-email-lmr@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On 2011-08-31 23:06, Lucas Meneghel Rodrigues wrote:
> Add a test device which supports the kvmctl ioports,
> for running the KVM test suite.
> 
> Usage:
> 
>   qemu
>      -chardev file,path=/log/file/some/where,id=testlog
>      -device pc-testdev,chardev=testlog
> 
> lmr: I've tried to address the comments made by the
> reviewers, but I probably left out some things. Please
> let me know whether this is on the right track.

Quite a few comments were missed (isa_get_irq, static iomem_buf etc.).
Please go through the thread again.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution v2
Date: Thu, 01 Sep 2011 09:22:39 +0200	[thread overview]
Message-ID: <4E5F32BF.4070801@web.de> (raw)
In-Reply-To: <1314824769-27740-1-git-send-email-lmr@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On 2011-08-31 23:06, Lucas Meneghel Rodrigues wrote:
> Add a test device which supports the kvmctl ioports,
> for running the KVM test suite.
> 
> Usage:
> 
>   qemu
>      -chardev file,path=/log/file/some/where,id=testlog
>      -device pc-testdev,chardev=testlog
> 
> lmr: I've tried to address the comments made by the
> reviewers, but I probably left out some things. Please
> let me know whether this is on the right track.

Quite a few comments were missed (isa_get_irq, static iomem_buf etc.).
Please go through the thread again.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  parent reply	other threads:[~2011-09-01  7:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 21:06 [PATCH] hw: Add test device for unittests execution v2 Lucas Meneghel Rodrigues
2011-08-31 21:06 ` [Qemu-devel] " Lucas Meneghel Rodrigues
2011-08-31 21:13 ` Edgar E. Iglesias
2011-08-31 21:13   ` Edgar E. Iglesias
2011-09-01  7:22 ` Jan Kiszka [this message]
2011-09-01  7:22   ` Jan Kiszka
2011-09-01  9:44 ` Paolo Bonzini
2011-09-01  9:44   ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5F32BF.4070801@web.de \
    --to=jan.kiszka@web.de \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.