* no new-line in setfiles/restorecon patch
@ 2011-09-01 4:11 Russell Coker
2011-09-01 13:44 ` Daniel J Walsh
0 siblings, 1 reply; 2+ messages in thread
From: Russell Coker @ 2011-09-01 4:11 UTC (permalink / raw)
To: SE-Linux
[-- Attachment #1: Type: Text/Plain, Size: 451 bytes --]
New-lines just look ugly when the screen width isn't 80 columns. Knowing
exactly how much progress we have made in increments of 80,000 isn't that
useful IMHO.
As an aside, I've been considering patching it to display "12345" instead of
"*****" as the progress. If you think this is a good idea then let me know
and I'll submit a patch to do it.
--
My Main Blog http://etbe.coker.com.au/
My Documents Blog http://doc.coker.com.au/
[-- Attachment #2: nonl.diff --]
[-- Type: text/x-patch, Size: 353 bytes --]
--- policycoreutils-2.1.0.orig/setfiles/restore.c
+++ policycoreutils-2.1.0/setfiles/restore.c
@@ -114,10 +114,6 @@
if (r_opts->progress) {
r_opts->count++;
- if (r_opts->count % (80 * STAR_COUNT) == 0) {
- fprintf(stdout, "\n");
- fflush(stdout);
- }
if (r_opts->count % STAR_COUNT == 0) {
fprintf(stdout, "*");
fflush(stdout);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: no new-line in setfiles/restorecon patch
2011-09-01 4:11 no new-line in setfiles/restorecon patch Russell Coker
@ 2011-09-01 13:44 ` Daniel J Walsh
0 siblings, 0 replies; 2+ messages in thread
From: Daniel J Walsh @ 2011-09-01 13:44 UTC (permalink / raw)
To: russell; +Cc: SE-Linux
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/01/2011 12:11 AM, Russell Coker wrote:
> New-lines just look ugly when the screen width isn't 80 columns.
> Knowing exactly how much progress we have made in increments of
> 80,000 isn't that useful IMHO.
>
> As an aside, I've been considering patching it to display "12345"
> instead of "*****" as the progress. If you think this is a good
> idea then let me know and I'll submit a patch to do it.
>
This looks good to me.
Ack.
Not sure the 123 would be useful.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk5fjE0ACgkQrlYvE4MpobOL4ACg3MA6J4ZJxj0jmAdPnRueed+5
+2gAoMK+qq31kl8ZKKGXyswAk6FqJERO
=AfE3
-----END PGP SIGNATURE-----
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-01 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-01 4:11 no new-line in setfiles/restorecon patch Russell Coker
2011-09-01 13:44 ` Daniel J Walsh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.