Re: [git:v4l-dvb/for_v3.2] [media] em28xx: use atomic bit operations for devices-in-use mask

Re: [git:v4l-dvb/for_v3.2] [media] em28xx: use atomic bit operations for devices-in-use mask

[Chris Rankin]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

On 04/09/11 00:49, Mauro Carvalho Chehab wrote:
> This is an automatic generated email to let you know that the following patch were queued at the
> http://git.linuxtv.org/media_tree.git tree:
>
> Subject: [media] em28xx: use atomic bit operations for devices-in-use mask
> Author:  Chris Rankin<rankincj@yahoo.com>
> Date:    Sat Aug 20 08:21:03 2011 -0300
>
> Use atomic bit operations for the em28xx_devused mask, to prevent an
> unlikely race condition should two adapters be plugged in
> simultaneously. The operations also clearer than explicit bit
> manipulation anyway.
>
> Signed-off-by: Chris Rankin<rankincj@yahoo.com>
> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>
>   drivers/media/video/em28xx/em28xx-cards.c |   33 ++++++++++++++---------------
>   1 files changed, 16 insertions(+), 17 deletions(-)

Hi Mauro,

I think you missed this line in the merge.

Cheers,
Chris

[-- Attachment #2: EM28xx-more-devunused-bits.diff --]
[-- Type: text/x-patch, Size: 380 bytes --]

--- linux/drivers/media/video/em28xx/em28xx-cards.c.orig	2011-09-04 20:17:00.000000000 +0100
+++ linux/drivers/media/video/em28xx/em28xx-cards.c	2011-09-04 20:19:21.000000000 +0100
@@ -3083,7 +3083,6 @@
 				em28xx_err(DRIVER_NAME " This is an anciliary "
 					"interface not used by the driver\n");
 
-				em28xx_devused &= ~(1<<nr);
 				retval = -ENODEV;
 				goto err;
 			}