From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Scott Jiang <scott.jiang.linux@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org,
uclinux-dist-devel@blackfin.uclinux.org,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 2/3] ASoC: Allow codecs to provide their own regmap configuration
Date: Mon, 05 Sep 2011 19:43:22 +0200 [thread overview]
Message-ID: <4E650A3A.5050807@metafoo.de> (raw)
In-Reply-To: <20110905172916.GG3889@opensource.wolfsonmicro.com>
On 09/05/2011 07:29 PM, Mark Brown wrote:
> On Mon, Sep 05, 2011 at 03:18:01PM +0200, Lars-Peter Clausen wrote:
>> Currently a codec can either do the whole regmap initialization on its own or
>> provide only the register and value bit size and let the core handle
>> initialization. This patch allows a codec to provide a complete regmap
>> configuration while still letting ASoC core handle the regmap initialization
>> and setup.
>
> I'd rather not do this, the only value is the copying of the word size
> setup out of the regmap config is to allow us to use the ASoC cache code
> but the idea is to push the cache down out of ASoC into the regmap code
> so this function should just be a trivial indirection for the regmap
> init which isn't useful.
>
I think it is useful, since we avoid duplicating that ugly switch statement
and we also have to wrap regmap_write and regmap_read, duplicating that in each
codec driver doesn't make sense.
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org,
device-drivers-devel@blackfin.uclinux.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org,
Scott Jiang <scott.jiang.linux@gmail.com>
Subject: Re: [PATCH 2/3] ASoC: Allow codecs to provide their own regmap configuration
Date: Mon, 05 Sep 2011 19:43:22 +0200 [thread overview]
Message-ID: <4E650A3A.5050807@metafoo.de> (raw)
In-Reply-To: <20110905172916.GG3889@opensource.wolfsonmicro.com>
On 09/05/2011 07:29 PM, Mark Brown wrote:
> On Mon, Sep 05, 2011 at 03:18:01PM +0200, Lars-Peter Clausen wrote:
>> Currently a codec can either do the whole regmap initialization on its own or
>> provide only the register and value bit size and let the core handle
>> initialization. This patch allows a codec to provide a complete regmap
>> configuration while still letting ASoC core handle the regmap initialization
>> and setup.
>
> I'd rather not do this, the only value is the copying of the word size
> setup out of the regmap config is to allow us to use the ASoC cache code
> but the idea is to push the cache down out of ASoC into the regmap code
> so this function should just be a trivial indirection for the regmap
> init which isn't useful.
>
I think it is useful, since we avoid duplicating that ugly switch statement
and we also have to wrap regmap_write and regmap_read, duplicating that in each
codec driver doesn't make sense.
next prev parent reply other threads:[~2011-09-05 17:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 13:18 [PATCH 1/3] regmap: Add support for device specific write and read flag masks Lars-Peter Clausen
2011-09-05 13:18 ` Lars-Peter Clausen
2011-09-05 13:18 ` [PATCH 2/3] ASoC: Allow codecs to provide their own regmap configuration Lars-Peter Clausen
2011-09-05 17:29 ` Mark Brown
2011-09-05 17:29 ` Mark Brown
2011-09-05 17:43 ` Lars-Peter Clausen [this message]
2011-09-05 17:43 ` Lars-Peter Clausen
2011-09-05 17:45 ` Mark Brown
2011-09-05 17:45 ` Mark Brown
2011-09-05 13:18 ` [PATCH 3/3] ASoC: ad193x: Setup regmap read and write flag masks for SPI Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E650A3A.5050807@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=scott.jiang.linux@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.