From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: "Saxena, Rahul" <rahul.saxena@intel.com>
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>,
Bruce Ashfield <bruce.ashfield@gmail.com>
Subject: Re: [PATCH 0/2] [KERNEL] Cover letter for seperating 10/100 LAN feature from 1G and 10G
Date: Thu, 8 Sep 2011 18:14:50 -0400 [thread overview]
Message-ID: <4E693E5A.7040204@windriver.com> (raw)
In-Reply-To: <4FF5AC937153B0459463C1A88EB478F2012E3F406F@orsmsx505.amr.corp.intel.com>
On 11-09-08 06:05 PM, Saxena, Rahul wrote:
> Cover letter for separating 10/100 LAN feature from 1G and 10G.
> Typically a machine does not need both of 10/100 and 1G/10G drivers.
The change looks fine, and I'd agree that this is a useful split.
BUT (there's always a but), there are a set of boards that are currently
including the e1xxxx feature that would currently be getting the e100,
and they'll no longer have it.
./bsp/common-pc/common-pc.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/fri2/fri2.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/fishriver/fishriver.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/romley/romley.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/emenlow/emenlow.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/crownbay/crownbay.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/common-pc-64/common-pc-64.scc:include
features/intel-e1xxxx/intel-e1xxxx.scc
In particular the common-pc really does want that config (for qemu).
So we should do the split, but also update all those boards to include
your new feature as part of this change.
Can you try and resend with that addition ? You don't need to built/boot,
just make the touches to the files listed above and I can take care of
the rest.
Bruce
>
> Signed-off-by: Rahul Saxena<Rahul.saxena@intel.com>
>
> Rahul Saxena (2):
>
> Remove 10/100 LAN support. 10/100 LAN will be configured by seperate
>
> files
>
> Added seperate feature for 10/100 LAN support
>
> .../features/intel-e1xxxx/intel-e100.cfg | 2 ++
>
> .../features/intel-e1xxxx/intel-e100.scc | 1 +
>
> .../features/intel-e1xxxx/intel-e1xxxx.cfg | 1 -
>
> 3 files changed, 3 insertions(+), 1 deletions(-)
>
> create mode 100644
> meta/cfg/kernel-cache/features/intel-e1xxxx/intel-e100.cfg
>
> create mode 100644
> meta/cfg/kernel-cache/features/intel-e1xxxx/intel-e100.scc
>
>
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
prev parent reply other threads:[~2011-09-08 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 22:05 [PATCH 0/2] [KERNEL] Cover letter for seperating 10/100 LAN feature from 1G and 10G Saxena, Rahul
2011-09-08 22:14 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E693E5A.7040204@windriver.com \
--to=bruce.ashfield@windriver.com \
--cc=bruce.ashfield@gmail.com \
--cc=rahul.saxena@intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.