* [PATCH 0/2] [KERNEL] Cover letter for seperating 10/100 LAN feature from 1G and 10G
@ 2011-09-08 22:05 Saxena, Rahul
2011-09-08 22:14 ` Bruce Ashfield
0 siblings, 1 reply; 2+ messages in thread
From: Saxena, Rahul @ 2011-09-08 22:05 UTC (permalink / raw)
To: yocto@yoctoproject.org; +Cc: Bruce Ashfield
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
Cover letter for separating 10/100 LAN feature from 1G and 10G. Typically a machine does not need both of 10/100 and 1G/10G drivers.
Signed-off-by: Rahul Saxena<Rahul.saxena@intel.com>
Rahul Saxena (2):
Remove 10/100 LAN support. 10/100 LAN will be configured by seperate
files
Added seperate feature for 10/100 LAN support
.../features/intel-e1xxxx/intel-e100.cfg | 2 ++
.../features/intel-e1xxxx/intel-e100.scc | 1 +
.../features/intel-e1xxxx/intel-e1xxxx.cfg | 1 -
3 files changed, 3 insertions(+), 1 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/intel-e1xxxx/intel-e100.cfg
create mode 100644 meta/cfg/kernel-cache/features/intel-e1xxxx/intel-e100.scc
[-- Attachment #2: Type: text/html, Size: 4606 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 0/2] [KERNEL] Cover letter for seperating 10/100 LAN feature from 1G and 10G
2011-09-08 22:05 [PATCH 0/2] [KERNEL] Cover letter for seperating 10/100 LAN feature from 1G and 10G Saxena, Rahul
@ 2011-09-08 22:14 ` Bruce Ashfield
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Ashfield @ 2011-09-08 22:14 UTC (permalink / raw)
To: Saxena, Rahul; +Cc: yocto@yoctoproject.org, Bruce Ashfield
On 11-09-08 06:05 PM, Saxena, Rahul wrote:
> Cover letter for separating 10/100 LAN feature from 1G and 10G.
> Typically a machine does not need both of 10/100 and 1G/10G drivers.
The change looks fine, and I'd agree that this is a useful split.
BUT (there's always a but), there are a set of boards that are currently
including the e1xxxx feature that would currently be getting the e100,
and they'll no longer have it.
./bsp/common-pc/common-pc.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/fri2/fri2.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/fishriver/fishriver.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/romley/romley.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/emenlow/emenlow.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/crownbay/crownbay.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/common-pc-64/common-pc-64.scc:include
features/intel-e1xxxx/intel-e1xxxx.scc
In particular the common-pc really does want that config (for qemu).
So we should do the split, but also update all those boards to include
your new feature as part of this change.
Can you try and resend with that addition ? You don't need to built/boot,
just make the touches to the files listed above and I can take care of
the rest.
Bruce
>
> Signed-off-by: Rahul Saxena<Rahul.saxena@intel.com>
>
> Rahul Saxena (2):
>
> Remove 10/100 LAN support. 10/100 LAN will be configured by seperate
>
> files
>
> Added seperate feature for 10/100 LAN support
>
> .../features/intel-e1xxxx/intel-e100.cfg | 2 ++
>
> .../features/intel-e1xxxx/intel-e100.scc | 1 +
>
> .../features/intel-e1xxxx/intel-e1xxxx.cfg | 1 -
>
> 3 files changed, 3 insertions(+), 1 deletions(-)
>
> create mode 100644
> meta/cfg/kernel-cache/features/intel-e1xxxx/intel-e100.cfg
>
> create mode 100644
> meta/cfg/kernel-cache/features/intel-e1xxxx/intel-e100.scc
>
>
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-08 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-08 22:05 [PATCH 0/2] [KERNEL] Cover letter for seperating 10/100 LAN feature from 1G and 10G Saxena, Rahul
2011-09-08 22:14 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.