From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCHv6 3/3] Mobile broadband provider info plugin
Date: Thu, 08 Sep 2011 23:58:35 -0500 [thread overview]
Message-ID: <4E699CFB.7090500@gmail.com> (raw)
In-Reply-To: <1316006204-11390-4-git-send-email-oleg.zhurakivskyy@intel.com>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
Hi Oleg,
On 09/14/2011 08:16 AM, Oleg Zhurakivskyy wrote:
> ---
> plugins/mobile-broadband-provider-info.c | 804 ++++++++++++++++++++++++++++++
> 1 files changed, 804 insertions(+), 0 deletions(-)
> create mode 100644 plugins/mobile-broadband-provider-info.c
>
After reviewing this patch I got the impression that you were still
making things just way too complicated and not taking full advantage of
the push/pop semantics. So just for fun I wrote my own version in
plugins/mbpi.[ch] and reworked tools/lookup-apn to use that. The code
seems to be valgrind clean and can handle duplicate detection, bail out
early, etc.
Can you please take a look and suggest improvements? Once you think it
is good enough, I'd like you to rewrite this patch series to utilize
mbpi.c parser.
Regards,
-Denis
next prev parent reply other threads:[~2011-09-09 4:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 13:16 [PATCHv6 0/3] Mobile broadband provider info plugin Oleg Zhurakivskyy
2011-09-14 13:16 ` [PATCHv6 1/3] Mobile broadband provider info plugin makefile changes Oleg Zhurakivskyy
2011-09-14 13:16 ` [PATCHv6 2/3] Mobile broadband provider info plugin autoconf support Oleg Zhurakivskyy
2011-09-14 13:16 ` [PATCHv6 3/3] Mobile broadband provider info plugin Oleg Zhurakivskyy
2011-09-09 4:58 ` Denis Kenzior [this message]
2011-09-20 13:44 ` Oleg Zhurakivskyy
2011-09-12 8:37 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E699CFB.7090500@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.