From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] Fix include statements for qemu-common.h
Date: Fri, 09 Sep 2011 10:16:24 +0200 [thread overview]
Message-ID: <4E69CB58.5020005@redhat.com> (raw)
In-Reply-To: <1315497332-7258-1-git-send-email-weil@mail.berlios.de>
Am 08.09.2011 17:55, schrieb Stefan Weil:
> * qemu-common.h is not a system include file, so it should be included
> with "" instead of <>. Otherwise incremental builds might fail
> because only local include files are checked for changes.
>
> * linux-user/syscall.c included the file twice.
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Acked-by: Kevin Wolf <kwolf@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Fix include statements for qemu-common.h
Date: Fri, 09 Sep 2011 10:16:24 +0200 [thread overview]
Message-ID: <4E69CB58.5020005@redhat.com> (raw)
In-Reply-To: <1315497332-7258-1-git-send-email-weil@mail.berlios.de>
Am 08.09.2011 17:55, schrieb Stefan Weil:
> * qemu-common.h is not a system include file, so it should be included
> with "" instead of <>. Otherwise incremental builds might fail
> because only local include files are checked for changes.
>
> * linux-user/syscall.c included the file twice.
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Acked-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2011-09-09 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 15:55 [Qemu-trivial] [PATCH] Fix include statements for qemu-common.h Stefan Weil
2011-09-08 15:55 ` [Qemu-devel] " Stefan Weil
2011-09-09 8:16 ` Kevin Wolf [this message]
2011-09-09 8:16 ` Kevin Wolf
2011-09-09 9:00 ` [Qemu-trivial] " Stefan Hajnoczi
2011-09-09 9:00 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E69CB58.5020005@redhat.com \
--to=kwolf@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.