Re: [Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev

[Kevin Wolf <kwolf@redhat.com>]

Am 07.09.2011 17:20, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  dma-helpers.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/dma-helpers.c b/dma-helpers.c
> index 4610ea0..ca97e14 100644
> --- a/dma-helpers.c
> +++ b/dma-helpers.c
> @@ -42,7 +42,7 @@ typedef struct {
>      BlockDriverAIOCB *acb;
>      QEMUSGList *sg;
>      uint64_t sector_num;
> -    int is_write;
> +    int to_dev;
>      int sg_cur_index;
>      target_phys_addr_t sg_cur_byte;
>      QEMUIOVector iov;

Should we take the opportunity to make it a bool? I think it would make
the purpose easier to understand.

Kevin