From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation
Date: Fri, 09 Sep 2011 15:43:14 +0200 [thread overview]
Message-ID: <4E6A17F2.1030705@redhat.com> (raw)
In-Reply-To: <4E6A15E1.7010009@redhat.com>
On 09/09/2011 03:34 PM, Kevin Wolf wrote:
> So the release that we avoid is the release in the callback that may or
> may not be called indirectly by bdrv_aio_cancel. We always call
> dma_complete at the end of dma_aio_cancel so that it will be properly freed.
>
>> In fact it may be worse than just the qemu_aio_release: if the driver is
>> waiting for the request to complete, it will write over the bounce
>> buffer after dma_bdrv_unmap has been called.
>
> How that? dma_bdrv_unmap is called only afterwards, isn't it?
I had missed your point completely. :) Yes, the above should work.
Paolo
next prev parent reply other threads:[~2011-09-09 13:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 15:20 [Qemu-devel] [PATCH 0/5] block: preparatory patches for scatter/gather support Paolo Bonzini
2011-09-07 15:20 ` [Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev Paolo Bonzini
2011-09-09 11:31 ` Kevin Wolf
2011-09-07 15:20 ` [Qemu-devel] [PATCH 2/5] dma-helpers: allow including from target-independent code Paolo Bonzini
2011-09-09 11:39 ` Kevin Wolf
2011-09-09 11:53 ` Paolo Bonzini
2011-09-07 15:21 ` [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation Paolo Bonzini
2011-09-09 12:14 ` Kevin Wolf
2011-09-09 12:43 ` Paolo Bonzini
2011-09-09 12:59 ` Kevin Wolf
2011-09-09 13:12 ` Paolo Bonzini
2011-09-09 13:34 ` Kevin Wolf
2011-09-09 13:43 ` Paolo Bonzini [this message]
2011-09-07 15:21 ` [Qemu-devel] [PATCH 4/5] scsi-disk: commonize iovec creation between reads and writes Paolo Bonzini
2011-09-07 15:21 ` [Qemu-devel] [PATCH 5/5] scsi-disk: lazily allocate bounce buffer Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6A17F2.1030705@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.