From: Benny Halevy <bhalevy@tonian.com>
To: Jim Rees <rees@umich.edu>
Cc: linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: Re: [PATCH] pnfsblock: fix size of upcall message
Date: Sat, 10 Sep 2011 00:29:33 -0700 [thread overview]
Message-ID: <4E6B11DD.1010905@tonian.com> (raw)
In-Reply-To: <1315599074-21412-1-git-send-email-rees@umich.edu>
On 2011-09-09 13:11, Jim Rees wrote:
> Make the status field explicitly 32 bits. "...it's unlikely that the kernel
> and userspace would differ on the size of an int here, but it might be a
> good idea to go ahead and make that explicitly 32 bits in case we end up
> dealing with more exotic arches at some point in the future."
>
> Suggested-by: Jeff Layton <jlayton@redhat.com>
> Signed-off-by: Jim Rees <rees@umich.edu>
merged. thanks!
Benny
> ---
> fs/nfs/blocklayout/blocklayout.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/blocklayout/blocklayout.h b/fs/nfs/blocklayout/blocklayout.h
> index 8900396..42acf7e 100644
> --- a/fs/nfs/blocklayout/blocklayout.h
> +++ b/fs/nfs/blocklayout/blocklayout.h
> @@ -150,7 +150,7 @@ BLK_LSEG2EXT(struct pnfs_layout_segment *lseg)
> }
>
> struct bl_dev_msg {
> - int status;
> + int32_t status;
> uint32_t major, minor;
> };
>
prev parent reply other threads:[~2011-09-10 7:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 20:11 [PATCH] pnfsblock: fix size of upcall message Jim Rees
2011-09-10 7:29 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6B11DD.1010905@tonian.com \
--to=bhalevy@tonian.com \
--cc=honey@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.