* [PATCH] pnfsblock: fix size of upcall message
@ 2011-09-09 20:11 Jim Rees
2011-09-10 7:29 ` Benny Halevy
0 siblings, 1 reply; 2+ messages in thread
From: Jim Rees @ 2011-09-09 20:11 UTC (permalink / raw)
To: Benny Halevy; +Cc: linux-nfs, peter honeyman
Make the status field explicitly 32 bits. "...it's unlikely that the kernel
and userspace would differ on the size of an int here, but it might be a
good idea to go ahead and make that explicitly 32 bits in case we end up
dealing with more exotic arches at some point in the future."
Suggested-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Jim Rees <rees@umich.edu>
---
fs/nfs/blocklayout/blocklayout.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/blocklayout/blocklayout.h b/fs/nfs/blocklayout/blocklayout.h
index 8900396..42acf7e 100644
--- a/fs/nfs/blocklayout/blocklayout.h
+++ b/fs/nfs/blocklayout/blocklayout.h
@@ -150,7 +150,7 @@ BLK_LSEG2EXT(struct pnfs_layout_segment *lseg)
}
struct bl_dev_msg {
- int status;
+ int32_t status;
uint32_t major, minor;
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pnfsblock: fix size of upcall message
2011-09-09 20:11 [PATCH] pnfsblock: fix size of upcall message Jim Rees
@ 2011-09-10 7:29 ` Benny Halevy
0 siblings, 0 replies; 2+ messages in thread
From: Benny Halevy @ 2011-09-10 7:29 UTC (permalink / raw)
To: Jim Rees; +Cc: linux-nfs, peter honeyman
On 2011-09-09 13:11, Jim Rees wrote:
> Make the status field explicitly 32 bits. "...it's unlikely that the kernel
> and userspace would differ on the size of an int here, but it might be a
> good idea to go ahead and make that explicitly 32 bits in case we end up
> dealing with more exotic arches at some point in the future."
>
> Suggested-by: Jeff Layton <jlayton@redhat.com>
> Signed-off-by: Jim Rees <rees@umich.edu>
merged. thanks!
Benny
> ---
> fs/nfs/blocklayout/blocklayout.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/blocklayout/blocklayout.h b/fs/nfs/blocklayout/blocklayout.h
> index 8900396..42acf7e 100644
> --- a/fs/nfs/blocklayout/blocklayout.h
> +++ b/fs/nfs/blocklayout/blocklayout.h
> @@ -150,7 +150,7 @@ BLK_LSEG2EXT(struct pnfs_layout_segment *lseg)
> }
>
> struct bl_dev_msg {
> - int status;
> + int32_t status;
> uint32_t major, minor;
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-10 7:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 20:11 [PATCH] pnfsblock: fix size of upcall message Jim Rees
2011-09-10 7:29 ` Benny Halevy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.