[PATCH] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[PATCH] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Steffen Sledz]

This patch is similar to the one in linux-libc-headers 2.6.23.

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 .../arm-hwcap-add-new-entries.patch                |   21 ++++++++++++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    6 +++-
 2 files changed, 25 insertions(+), 2 deletions(-)
 create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch

diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
new file mode 100644
index 0000000..6975317
--- /dev/null
+++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
@@ -0,0 +1,21 @@
+---
+ include/asm-arm/hwcap.h |    4 ++++
+ 1 file changed, 4 insertions(+)
+
+--- linux-2.6.24.orig/include/asm-arm/hwcap.h
++++ linux-2.6.24/include/asm-arm/hwcap.h
+@@ -13,10 +13,14 @@
+ #define HWCAP_VFP	64
+ #define HWCAP_EDSP	128
+ #define HWCAP_JAVA	256
+ #define HWCAP_IWMMXT	512
+ #define HWCAP_CRUNCH	1024
++#define HWCAP_THUMBEE	2048
++#define HWCAP_NEON	4096
++#define HWCAP_VFPv3	8192
++#define HWCAP_VFPv3D16	16384
+ 
+ #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
+ /*
+  * This yields a mask that user programs can use to figure out what
+  * instruction set this cpu supports.
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index 148d03f..e321351 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -2,16 +2,18 @@ require linux-libc-headers.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
-PR = "r7"
+PR = "r8"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
            file://export_falloc_h.patch \
            file://make-3.82.patch \
-           file://unifdef.patch"
+           file://unifdef.patch \
+           file://arm-hwcap-add-new-entries.patch"
 
 SRC_URI_append_hipox = " \
 	file://siocoutqsnd.patch \
+	file://drbcc-linedisc.patch \
 	"
 
 S = "${WORKDIR}/linux-${PV}"
-- 
1.7.3.4

Re: [PATCH] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Steffen Sledz]

On 09.09.2011 17:22, Steffen Sledz wrote:
> This patch is similar to the one in linux-libc-headers 2.6.23.

No NACKs? Then i'll push this patch tomorrow to oe-dev master.

> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  .../arm-hwcap-add-new-entries.patch                |   21 ++++++++++++++++++++
>  .../linux-libc-headers_2.6.24.bb                   |    6 +++-
>  2 files changed, 25 insertions(+), 2 deletions(-)
>  create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> 
> diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> new file mode 100644
> index 0000000..6975317
> --- /dev/null
> +++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> @@ -0,0 +1,21 @@
> +---
> + include/asm-arm/hwcap.h |    4 ++++
> + 1 file changed, 4 insertions(+)
> +
> +--- linux-2.6.24.orig/include/asm-arm/hwcap.h
> ++++ linux-2.6.24/include/asm-arm/hwcap.h
> +@@ -13,10 +13,14 @@
> + #define HWCAP_VFP	64
> + #define HWCAP_EDSP	128
> + #define HWCAP_JAVA	256
> + #define HWCAP_IWMMXT	512
> + #define HWCAP_CRUNCH	1024
> ++#define HWCAP_THUMBEE	2048
> ++#define HWCAP_NEON	4096
> ++#define HWCAP_VFPv3	8192
> ++#define HWCAP_VFPv3D16	16384
> + 
> + #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
> + /*
> +  * This yields a mask that user programs can use to figure out what
> +  * instruction set this cpu supports.
> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> index 148d03f..e321351 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> @@ -2,16 +2,18 @@ require linux-libc-headers.inc
>  
>  INHIBIT_DEFAULT_DEPS = "1"
>  DEPENDS += "unifdef-native"
> -PR = "r7"
> +PR = "r8"
>  
>  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
>             file://procinfo.h \
>             file://export_falloc_h.patch \
>             file://make-3.82.patch \
> -           file://unifdef.patch"
> +           file://unifdef.patch \
> +           file://arm-hwcap-add-new-entries.patch"
>  
>  SRC_URI_append_hipox = " \
>  	file://siocoutqsnd.patch \
> +	file://drbcc-linedisc.patch \
>  	"
>  
>  S = "${WORKDIR}/linux-${PV}"

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [PATCH] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

Am Montag, den 12.09.2011, 16:58 +0200 schrieb Steffen Sledz:
> On 09.09.2011 17:22, Steffen Sledz wrote:
> > This patch is similar to the one in linux-libc-headers 2.6.23.
> 
> No NACKs? Then i'll push this patch tomorrow to oe-dev master.

To make acking easier, it would be nice to have more information in the
commit message.

1. Reference or URL to the ID of the commit to 2.6.23.
2. What is the addition used for?
3. Has it been tested? How?

Otherwise the list seems to be pretty calm recently. I do not know how
it could be revived.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Marcin Juszkiewicz]

W dniu 12.09.2011 16:58, Steffen Sledz pisze:
>  SRC_URI_append_hipox = " \
>>  	file://siocoutqsnd.patch \
>> +	file://drbcc-linedisc.patch \
>>  	"
>>  

This got added... so NACK.

[PATCH v2] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Steffen Sledz]

This patch is similar to the one in linux-libc-headers 2.6.23 [1] and
enables building of OpenJDK which uses HWCAP_THUMBEE which normally
are not present in 2.6.24 headers.

[1] commit 41cd62ffbac7d272d46a4b39faf8a97c0850dd10

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 .../arm-hwcap-add-new-entries.patch                |   21 ++++++++++++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    5 ++-
 2 files changed, 24 insertions(+), 2 deletions(-)
 create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch

diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
new file mode 100644
index 0000000..6975317
--- /dev/null
+++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
@@ -0,0 +1,21 @@
+---
+ include/asm-arm/hwcap.h |    4 ++++
+ 1 file changed, 4 insertions(+)
+
+--- linux-2.6.24.orig/include/asm-arm/hwcap.h
++++ linux-2.6.24/include/asm-arm/hwcap.h
+@@ -13,10 +13,14 @@
+ #define HWCAP_VFP	64
+ #define HWCAP_EDSP	128
+ #define HWCAP_JAVA	256
+ #define HWCAP_IWMMXT	512
+ #define HWCAP_CRUNCH	1024
++#define HWCAP_THUMBEE	2048
++#define HWCAP_NEON	4096
++#define HWCAP_VFPv3	8192
++#define HWCAP_VFPv3D16	16384
+ 
+ #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
+ /*
+  * This yields a mask that user programs can use to figure out what
+  * instruction set this cpu supports.
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index 148d03f..cec1835 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -2,13 +2,14 @@ require linux-libc-headers.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
-PR = "r7"
+PR = "r8"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
            file://export_falloc_h.patch \
            file://make-3.82.patch \
-           file://unifdef.patch"
+           file://unifdef.patch \
+           file://arm-hwcap-add-new-entries.patch"
 
 SRC_URI_append_hipox = " \
 	file://siocoutqsnd.patch \
-- 
1.7.3.4

Re: [PATCH v2] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 3158 bytes --]

Dear Steffen,


Am Montag, den 12.09.2011, 17:26 +0200 schrieb Steffen Sledz:
> This patch is similar to the one in linux-libc-headers 2.6.23 [1] and
> enables building of OpenJDK which uses HWCAP_THUMBEE which normally
> are not present in 2.6.24 headers.
> 
> [1] commit 41cd62ffbac7d272d46a4b39faf8a97c0850dd10

thank you for updating the patch and the commit message.

> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  .../arm-hwcap-add-new-entries.patch                |   21 ++++++++++++++++++++
>  .../linux-libc-headers_2.6.24.bb                   |    5 ++-
>  2 files changed, 24 insertions(+), 2 deletions(-)
>  create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> 
> diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> new file mode 100644
> index 0000000..6975317
> --- /dev/null
> +++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> @@ -0,0 +1,21 @@

I am not sure about the policy in oe.dev, but could you add a patch
header, please [1].

Upstream-Status: Backport [2.6.(which one?)]

> +---
> + include/asm-arm/hwcap.h |    4 ++++
> + 1 file changed, 4 insertions(+)
> +
> +--- linux-2.6.24.orig/include/asm-arm/hwcap.h
> ++++ linux-2.6.24/include/asm-arm/hwcap.h
> +@@ -13,10 +13,14 @@
> + #define HWCAP_VFP	64
> + #define HWCAP_EDSP	128
> + #define HWCAP_JAVA	256
> + #define HWCAP_IWMMXT	512
> + #define HWCAP_CRUNCH	1024
> ++#define HWCAP_THUMBEE	2048
> ++#define HWCAP_NEON	4096
> ++#define HWCAP_VFPv3	8192
> ++#define HWCAP_VFPv3D16	16384
> + 
> + #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
> + /*
> +  * This yields a mask that user programs can use to figure out what
> +  * instruction set this cpu supports.
> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> index 148d03f..cec1835 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> @@ -2,13 +2,14 @@ require linux-libc-headers.inc
>  
>  INHIBIT_DEFAULT_DEPS = "1"
>  DEPENDS += "unifdef-native"
> -PR = "r7"
> +PR = "r8"
>  
>  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
>             file://procinfo.h \
>             file://export_falloc_h.patch \
>             file://make-3.82.patch \
> -           file://unifdef.patch"
> +           file://unifdef.patch \
> +           file://arm-hwcap-add-new-entries.patch"

To keep future patches smaller could you put the »"« on the new line
please?

        ….patch \
        "
 
>  SRC_URI_append_hipox = " \
>  	file://siocoutqsnd.patch \

With these changes please add

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>

below your Signed-off-by line.


Thanks,

Paul


[1] http://openembedded.org/index.php?title=Commit_Patch_Message_Guidelines#Patch_Header_Recommendations

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Steffen Sledz]

On 13.09.2011 11:45, Paul Menzel wrote:
> Dear Steffen,
> 
> 
> Am Montag, den 12.09.2011, 17:26 +0200 schrieb Steffen Sledz:
>> This patch is similar to the one in linux-libc-headers 2.6.23 [1] and
>> enables building of OpenJDK which uses HWCAP_THUMBEE which normally
>> are not present in 2.6.24 headers.
>>
>> [1] commit 41cd62ffbac7d272d46a4b39faf8a97c0850dd10
> 
> thank you for updating the patch and the commit message.
> 
>> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
>> ---
>>  .../arm-hwcap-add-new-entries.patch                |   21 ++++++++++++++++++++
>>  .../linux-libc-headers_2.6.24.bb                   |    5 ++-
>>  2 files changed, 24 insertions(+), 2 deletions(-)
>>  create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
>>
>> diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
>> new file mode 100644
>> index 0000000..6975317
>> --- /dev/null
>> +++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
>> @@ -0,0 +1,21 @@
> 
> I am not sure about the policy in oe.dev, but could you add a patch
> header, please [1].
> 
> Upstream-Status: Backport [2.6.(which one?)]

Marcin, can you write something to this? I just adapted your patch to the 2.6.24 headers.

>> +---
>> + include/asm-arm/hwcap.h |    4 ++++
>> + 1 file changed, 4 insertions(+)
>> +
>> +--- linux-2.6.24.orig/include/asm-arm/hwcap.h
>> ++++ linux-2.6.24/include/asm-arm/hwcap.h
>> +@@ -13,10 +13,14 @@
>> + #define HWCAP_VFP	64
>> + #define HWCAP_EDSP	128
>> + #define HWCAP_JAVA	256
>> + #define HWCAP_IWMMXT	512
>> + #define HWCAP_CRUNCH	1024
>> ++#define HWCAP_THUMBEE	2048
>> ++#define HWCAP_NEON	4096
>> ++#define HWCAP_VFPv3	8192
>> ++#define HWCAP_VFPv3D16	16384
>> + 
>> + #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
>> + /*
>> +  * This yields a mask that user programs can use to figure out what
>> +  * instruction set this cpu supports.
>> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
>> index 148d03f..cec1835 100644
>> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
>> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
>> @@ -2,13 +2,14 @@ require linux-libc-headers.inc
>>  
>>  INHIBIT_DEFAULT_DEPS = "1"
>>  DEPENDS += "unifdef-native"
>> -PR = "r7"
>> +PR = "r8"
>>  
>>  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
>>             file://procinfo.h \
>>             file://export_falloc_h.patch \
>>             file://make-3.82.patch \
>> -           file://unifdef.patch"
>> +           file://unifdef.patch \
>> +           file://arm-hwcap-add-new-entries.patch"
> 
> To keep future patches smaller could you put the »"« on the new line
> please?
> 
>         ….patch \
>         "

Yepp. No problem.

>>  SRC_URI_append_hipox = " \
>>  	file://siocoutqsnd.patch \
> 
> With these changes please add
> 
> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> below your Signed-off-by line.
> 
> 
> Thanks,
> 
> Paul
> 
> 
> [1] http://openembedded.org/index.php?title=Commit_Patch_Message_Guidelines#Patch_Header_Recommendations
> 
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [PATCH v2] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Marcin Juszkiewicz]

W dniu 13.09.2011 11:58, Steffen Sledz pisze:
>> > I am not sure about the policy in oe.dev, but could you add a patch
>> > header, please [1].
>> > 
>> > Upstream-Status: Backport [2.6.(which one?)]
> Marcin, can you write something to this? I just adapted your patch to the 2.6.24 headers.

In BugLabs we used Poky 'pinky' and then switched to OpenEmbedded
2009-stable tree. At that time we used 2.6.2x linux-libc-headers as this
was present in both trees and selected by default.

When BUG 2.0 prototypes started working we started move from phoneme to
openjdk as java-vm provider. To build openjdk newer linux-libc-headers
were needed due to lack of HWCAP_THUMBEE define in 2.6.2x ones. Patching
default version was better solution then switching to newer one as it
gave us smaller chance of build failures.

And that's whole story of it.

Re: [PATCH v2] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernels

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 3512 bytes --]

Dear Steffen, dear Marcin,


Am Dienstag, den 13.09.2011, 11:45 +0200 schrieb Paul Menzel:

> Am Montag, den 12.09.2011, 17:26 +0200 schrieb Steffen Sledz:
> > This patch is similar to the one in linux-libc-headers 2.6.23 [1] and
> > enables building of OpenJDK which uses HWCAP_THUMBEE which normally
> > are not present in 2.6.24 headers.
> > 
> > [1] commit 41cd62ffbac7d272d46a4b39faf8a97c0850dd10
> 
> thank you for updating the patch and the commit message.
> 
> > Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> > ---
> >  .../arm-hwcap-add-new-entries.patch                |   21 ++++++++++++++++++++
> >  .../linux-libc-headers_2.6.24.bb                   |    5 ++-
> >  2 files changed, 24 insertions(+), 2 deletions(-)
> >  create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> > 
> > diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> > new file mode 100644
> > index 0000000..6975317
> > --- /dev/null
> > +++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> > @@ -0,0 +1,21 @@
> 
> I am not sure about the policy in oe.dev, but could you add a patch
> header, please [1].
> 
> Upstream-Status: Backport [2.6.(which one?)]

Looking at your patch and the relevant Linux kernel commits, I do not
see how this can come from mainline Linux.

> > +---
> > + include/asm-arm/hwcap.h |    4 ++++
> > + 1 file changed, 4 insertions(+)
> > +
> > +--- linux-2.6.24.orig/include/asm-arm/hwcap.h
> > ++++ linux-2.6.24/include/asm-arm/hwcap.h
> > +@@ -13,10 +13,14 @@
> > + #define HWCAP_VFP	64
> > + #define HWCAP_EDSP	128
> > + #define HWCAP_JAVA	256
> > + #define HWCAP_IWMMXT	512
> > + #define HWCAP_CRUNCH	1024
> > ++#define HWCAP_THUMBEE	2048

This is already there in the original file creation.

        commit 4baa9922430662431231ac637adedddbb0cfb2d7
        Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
        Date:   Sat Aug 2 10:55:55 2008 +0100
        
            [ARM] move include/asm-arm to arch/arm/include/asm

        $ git describe --contains 4baa9922
        v2.6.27-rc2~72^2~2

> > ++#define HWCAP_NEON	4096

        commit 2bedbdf4148ebbe48c7a89449ab52e475a788f42
        Author: Catalin Marinas <catalin.marinas@arm.com>
        Date:   Thu Nov 6 13:23:07 2008 +0000
        
            Add HWCAP_NEON to the ARM hwcap.h file

        $ git describe --contains 2bedbdf4
        v2.6.29-rc1~559^2~84^2~7

> > ++#define HWCAP_VFPv3	8192
> > ++#define HWCAP_VFPv3D16	16384

        commit 7279dc3e914635ab4b288ec39383272a06c466f3
        Author: Catalin Marinas <catalin.marinas@arm.com>
        Date:   Wed Feb 11 13:13:56 2009 +0100
        
            [ARM] 5388/1: Add hwcap bits for VFPv3 and VFPv3D16

After figuring that out I would just put these commit messages excerpts
into the patch header.

By the way, the Linux kernel version the last patch was merged is
therefore 2.6.30.

        $ git describe --contains 7279dc3e
        v2.6.30-rc1~636^2~52^2~24

So the commit summary could be updated to be more specific.

> > +
> > + #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
> > + /*
> > +  * This yields a mask that user programs can use to figure out what
> > +  * instruction set this cpu supports.

[…]


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

[PATCH v3] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel

[Steffen Sledz]

Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
in 2.6.24 headers and was introduced with

  commit 4baa9922430662431231ac637adedddbb0cfb2d7
  Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
  Date:   Sat Aug 2 10:55:55 2008 +0100

      [ARM] move include/asm-arm to arch/arm/include/asm

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 .../arm-hwcap-add-new-entries.patch                |   26 ++++++++++++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    5 ++-
 2 files changed, 29 insertions(+), 2 deletions(-)
 create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch

diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
new file mode 100644
index 0000000..c127970
--- /dev/null
+++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
@@ -0,0 +1,26 @@
+linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel
+
+Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
+in 2.6.24 headers and was introduced with
+
+  commit 4baa9922430662431231ac637adedddbb0cfb2d7
+  Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
+  Date:   Sat Aug 2 10:55:55 2008 +0100
+
+      [ARM] move include/asm-arm to arch/arm/include/asm
+
+Upstream-Status: Backport [2.6.27]
+
+Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
+
+diff -Nurd linux-2.6.24.orig//include/asm-arm/hwcap.h linux-2.6.24/include/asm-arm/hwcap.h
+--- linux-2.6.24.orig//include/asm-arm/hwcap.h	2011-09-15 08:42:58.467307245 +0200
++++ linux-2.6.24/include/asm-arm/hwcap.h	2011-09-15 08:43:46.004693497 +0200
+@@ -15,6 +15,7 @@
+ #define HWCAP_JAVA	256
+ #define HWCAP_IWMMXT	512
+ #define HWCAP_CRUNCH	1024
++#define HWCAP_THUMBEE	2048
+ 
+ #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
+ /*
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index 148d03f..cec1835 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -2,13 +2,14 @@ require linux-libc-headers.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
-PR = "r7"
+PR = "r8"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
            file://export_falloc_h.patch \
            file://make-3.82.patch \
-           file://unifdef.patch"
+           file://unifdef.patch \
+           file://arm-hwcap-add-new-entries.patch"
 
 SRC_URI_append_hipox = " \
 	file://siocoutqsnd.patch \
-- 
1.7.3.4

[PATCH v4] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel

[Steffen Sledz]

Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
in 2.6.24 headers and was introduced with

  commit 4baa9922430662431231ac637adedddbb0cfb2d7
  Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
  Date:   Sat Aug 2 10:55:55 2008 +0100

      [ARM] move include/asm-arm to arch/arm/include/asm

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 .../arm-hwcap-add-new-entries.patch                |   26 ++++++++++++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    6 +++-
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch

diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
new file mode 100644
index 0000000..c127970
--- /dev/null
+++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
@@ -0,0 +1,26 @@
+linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel
+
+Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
+in 2.6.24 headers and was introduced with
+
+  commit 4baa9922430662431231ac637adedddbb0cfb2d7
+  Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
+  Date:   Sat Aug 2 10:55:55 2008 +0100
+
+      [ARM] move include/asm-arm to arch/arm/include/asm
+
+Upstream-Status: Backport [2.6.27]
+
+Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
+
+diff -Nurd linux-2.6.24.orig//include/asm-arm/hwcap.h linux-2.6.24/include/asm-arm/hwcap.h
+--- linux-2.6.24.orig//include/asm-arm/hwcap.h	2011-09-15 08:42:58.467307245 +0200
++++ linux-2.6.24/include/asm-arm/hwcap.h	2011-09-15 08:43:46.004693497 +0200
+@@ -15,6 +15,7 @@
+ #define HWCAP_JAVA	256
+ #define HWCAP_IWMMXT	512
+ #define HWCAP_CRUNCH	1024
++#define HWCAP_THUMBEE	2048
+ 
+ #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
+ /*
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index 148d03f..d7f67ed 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -2,13 +2,15 @@ require linux-libc-headers.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
-PR = "r7"
+PR = "r8"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
            file://export_falloc_h.patch \
            file://make-3.82.patch \
-           file://unifdef.patch"
+           file://unifdef.patch \
+           file://arm-hwcap-add-new-entries.patch \
+"
 
 SRC_URI_append_hipox = " \
 	file://siocoutqsnd.patch \
-- 
1.7.3.4

Re: [PATCH v4] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2492 bytes --]

Dear Steffen,


unfortunately I still have something to add. :(

Am Donnerstag, den 15.09.2011, 09:55 +0200 schrieb Steffen Sledz:

1. Please do not use `recent` but write the correct version. In this
case it would be 2.6.26 (see below).

> Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
> in 2.6.24 headers and was introduced with
> 
>   commit 4baa9922430662431231ac637adedddbb0cfb2d7
>   Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
>   Date:   Sat Aug 2 10:55:55 2008 +0100
> 
>       [ARM] move include/asm-arm to arch/arm/include/asm

2. Of course that is not correct and I asked that in my last response
why a move should introduce new code lines.

Using

        git log --follow 4baa9922430662431231ac637adedddbb0cfb2d7 -- arch/arm/include/asm/hwcap.h

I found the following commit

        commit d7f864be8323e5394040e2877594645b0e7da85d
        Author: Catalin Marinas <catalin.marinas@arm.com>
        Date:   Fri Apr 18 22:43:06 2008 +0100
        
            ARMv7: Add support for the ThumbEE state saving/restoring
            
            This patch adds the detection and handling of the ThumbEE extension on
            ARMv7 CPUs.
            
            Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

introduced in 2.6.26.

        $ git describe --contains
        d7f864be8323e5394040e2877594645b0e7da85d
        v2.6.26-rc1~1090^2~27

Please note that this commit contains not only the addition of
HWCAP_THUMBEE to the header but a lot more. So is OpenJDK doing
something incorrectly then? Does it detect the wrong architecture?

> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
>  .../arm-hwcap-add-new-entries.patch                |   26 ++++++++++++++++++++
>  .../linux-libc-headers_2.6.24.bb                   |    6 +++-
>  2 files changed, 30 insertions(+), 2 deletions(-)
>  create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch

[…]

Please update the relevant parts and send it to the list again. You can
commit it the next day if nobody else objects.


Thanks,

Paul


PS: It is hard for reviewers to see what changed in your patch
iterations. For example between v3 and v4. Please add a short note below
the commit message and separate that with an additional `---`. `git am`
will not pick that comment up then.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v4] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel

[Steffen Sledz]

On 15.09.2011 11:05, Paul Menzel wrote:
> PS: It is hard for reviewers to see what changed in your patch iterations. For example between v3 and v4. Please add a short note below the commit message and separate that with an additional `---`. `git am` will not pick that comment up then.

Is it possible to add such a comment while running "git format-patch" or "git send-email"?

Or is it necessary to mix this into the commit comment itself?

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

[PATCH v5] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from linux 2.6.26

[Steffen Sledz]

Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
in 2.6.24 headers and was introduced with

  commit d7f864be8323e5394040e2877594645b0e7da85d
  Author: Catalin Marinas <catalin.marinas@arm.com>
  Date:   Fri Apr 18 22:43:06 2008 +0100

      ARMv7: Add support for the ThumbEE state saving/restoring

      This patch adds the detection and handling of the ThumbEE extension on
      ARMv7 CPUs.

      Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

Upstream-Status: Backport [2.6.26]

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
[PATCH v5] contains updates in commit comment and patch header as a result of
Paul's review of [PATCH v4] especially the referenced linux commit.
---
 .../arm-hwcap-add-new-entries.patch                |   31 ++++++++++++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    6 ++-
 2 files changed, 35 insertions(+), 2 deletions(-)
 create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch

diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
new file mode 100644
index 0000000..80a7949
--- /dev/null
+++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
@@ -0,0 +1,31 @@
+linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from linux 2.6.26
+
+Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
+in 2.6.24 headers and was introduced with
+
+  commit d7f864be8323e5394040e2877594645b0e7da85d
+  Author: Catalin Marinas <catalin.marinas@arm.com>
+  Date:   Fri Apr 18 22:43:06 2008 +0100
+  
+      ARMv7: Add support for the ThumbEE state saving/restoring
+      
+      This patch adds the detection and handling of the ThumbEE extension on
+      ARMv7 CPUs.
+            
+      Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
+
+Upstream-Status: Backport [2.6.26]
+
+Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
+
+diff -Nurd linux-2.6.24.orig//include/asm-arm/hwcap.h linux-2.6.24/include/asm-arm/hwcap.h
+--- linux-2.6.24.orig//include/asm-arm/hwcap.h	2011-09-15 08:42:58.467307245 +0200
++++ linux-2.6.24/include/asm-arm/hwcap.h	2011-09-15 08:43:46.004693497 +0200
+@@ -15,6 +15,7 @@
+ #define HWCAP_JAVA	256
+ #define HWCAP_IWMMXT	512
+ #define HWCAP_CRUNCH	1024
++#define HWCAP_THUMBEE	2048
+ 
+ #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
+ /*
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index 148d03f..d7f67ed 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -2,13 +2,15 @@ require linux-libc-headers.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
-PR = "r7"
+PR = "r8"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
            file://export_falloc_h.patch \
            file://make-3.82.patch \
-           file://unifdef.patch"
+           file://unifdef.patch \
+           file://arm-hwcap-add-new-entries.patch \
+"
 
 SRC_URI_append_hipox = " \
 	file://siocoutqsnd.patch \
-- 
1.7.3.4

Re: [PATCH v4] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

Am Donnerstag, den 15.09.2011, 13:54 +0200 schrieb Steffen Sledz:
> On 15.09.2011 11:05, Paul Menzel wrote:
> > PS: It is hard for reviewers to see what changed in your patch iterations. For example between v3 and v4. Please add a short note below the commit message and separate that with an additional `---`. `git am` will not pick that comment up then.
> 
> Is it possible to add such a comment while running "git format-patch" or "git send-email"?

I do not know of a way and I did not find anything in the manual. I
guess you have to edit the mbox file created by `git format-patch` and
then send it.

Other people also use the cover letter feature. But in all cases it
seems to be one step more.

> Or is it necessary to mix this into the commit comment itself?

No, since `git push` is not leaving the comment out.

Thank you again for addressing my comments.


Thanks,

Paul



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v4] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel

[Steffen Sledz]

On 15.09.2011 16:56, Paul Menzel wrote:
> Am Donnerstag, den 15.09.2011, 13:54 +0200 schrieb Steffen Sledz:
>> On 15.09.2011 11:05, Paul Menzel wrote:
>>> PS: It is hard for reviewers to see what changed in your patch iterations. For example between v3 and v4. Please add a short note below the commit message and separate that with an additional `---`. `git am` will not pick that comment up then.
>>
>> Is it possible to add such a comment while running "git format-patch" or "git send-email"?
> 
> I do not know of a way and I did not find anything in the manual. I
> guess you have to edit the mbox file created by `git format-patch` and
> then send it.

After reading the manual i found the --annotate option for "git send-email" which helped me here.

Steffen

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [PATCH v5] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from linux 2.6.26

[Steffen Sledz]

On 15.09.2011 14:29, Steffen Sledz wrote:
> Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
> in 2.6.24 headers and was introduced with
> 
>   commit d7f864be8323e5394040e2877594645b0e7da85d
>   Author: Catalin Marinas <catalin.marinas@arm.com>
>   Date:   Fri Apr 18 22:43:06 2008 +0100
> 
>       ARMv7: Add support for the ThumbEE state saving/restoring
> 
>       This patch adds the detection and handling of the ThumbEE extension on
>       ARMv7 CPUs.
> 
>       Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> 
> Upstream-Status: Backport [2.6.26]
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
> [PATCH v5] contains updates in commit comment and patch header as a result of
> Paul's review of [PATCH v4] especially the referenced linux commit.
> ---
>  .../arm-hwcap-add-new-entries.patch                |   31 ++++++++++++++++++++
>  .../linux-libc-headers_2.6.24.bb                   |    6 ++-
>  2 files changed, 35 insertions(+), 2 deletions(-)
>  create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> 
> diff --git a/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> new file mode 100644
> index 0000000..80a7949
> --- /dev/null
> +++ b/recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch
> @@ -0,0 +1,31 @@
> +linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from linux 2.6.26
> +
> +Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
> +in 2.6.24 headers and was introduced with
> +
> +  commit d7f864be8323e5394040e2877594645b0e7da85d
> +  Author: Catalin Marinas <catalin.marinas@arm.com>
> +  Date:   Fri Apr 18 22:43:06 2008 +0100
> +  
> +      ARMv7: Add support for the ThumbEE state saving/restoring
> +      
> +      This patch adds the detection and handling of the ThumbEE extension on
> +      ARMv7 CPUs.
> +            
> +      Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> +
> +Upstream-Status: Backport [2.6.26]
> +
> +Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> +
> +diff -Nurd linux-2.6.24.orig//include/asm-arm/hwcap.h linux-2.6.24/include/asm-arm/hwcap.h
> +--- linux-2.6.24.orig//include/asm-arm/hwcap.h	2011-09-15 08:42:58.467307245 +0200
> ++++ linux-2.6.24/include/asm-arm/hwcap.h	2011-09-15 08:43:46.004693497 +0200
> +@@ -15,6 +15,7 @@
> + #define HWCAP_JAVA	256
> + #define HWCAP_IWMMXT	512
> + #define HWCAP_CRUNCH	1024
> ++#define HWCAP_THUMBEE	2048
> + 
> + #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
> + /*
> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> index 148d03f..d7f67ed 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> @@ -2,13 +2,15 @@ require linux-libc-headers.inc
>  
>  INHIBIT_DEFAULT_DEPS = "1"
>  DEPENDS += "unifdef-native"
> -PR = "r7"
> +PR = "r8"
>  
>  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
>             file://procinfo.h \
>             file://export_falloc_h.patch \
>             file://make-3.82.patch \
> -           file://unifdef.patch"
> +           file://unifdef.patch \
> +           file://arm-hwcap-add-new-entries.patch \
> +"
>  
>  SRC_URI_append_hipox = " \
>  	file://siocoutqsnd.patch \

applied and pushed

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058