[PATCH V4] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

[PATCH V4] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

[Tushar Behera]

ORIGEN board is fitted with 7" LCD panel HV070WSA. The pixel
resolution of the LCD panel is 1024x600.

Also power domain device for LCD0 is registered.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
Changes for V4:
	* Added gpio_free() call
	* Removed .refresh value as it was same as default value.
Changes for V3:
	* Added error check for gpio request in LCD power function
Changes for V2:
	* Added power domain device registration for LCD0

 arch/arm/mach-exynos4/Kconfig       |    3 ++
 arch/arm/mach-exynos4/mach-origen.c |   60 +++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index 48f18f7..4f28871 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -222,6 +222,9 @@ config MACH_ORIGEN
 	select S3C_DEV_RTC
 	select S3C_DEV_WDT
 	select S3C_DEV_HSMMC2
+	select S5P_DEV_FIMD0
+	select EXYNOS4_DEV_PD
+	select EXYNOS4_SETUP_FIMD0
 	select EXYNOS4_SETUP_SDHCI
 	help
 	  Machine support for ORIGEN based on Samsung EXYNOS4210
diff --git a/arch/arm/mach-exynos4/mach-origen.c b/arch/arm/mach-exynos4/mach-origen.c
index ed59f86..0833fcb 100644
--- a/arch/arm/mach-exynos4/mach-origen.c
+++ b/arch/arm/mach-exynos4/mach-origen.c
@@ -14,16 +14,22 @@
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/input.h>
+#include <linux/lcd.h>
+
+#include <video/platform_lcd.h>
 
 #include <asm/mach/arch.h>
 #include <asm/mach-types.h>
 
 #include <plat/regs-serial.h>
+#include <plat/regs-fb-v4.h>
 #include <plat/exynos4.h>
 #include <plat/cpu.h>
 #include <plat/devs.h>
 #include <plat/sdhci.h>
 #include <plat/iic.h>
+#include <plat/pd.h>
+#include <plat/fb.h>
 
 #include <mach/map.h>
 
@@ -79,10 +85,62 @@ static struct s3c_sdhci_platdata origen_hsmmc2_pdata __initdata = {
 	.clk_type		= S3C_SDHCI_CLK_DIV_EXTERNAL,
 };
 
+static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, unsigned int power)
+{
+	int ret;
+
+	if (power)
+		ret = gpio_request_one(EXYNOS4_GPE3(4),
+					GPIOF_OUT_INIT_HIGH, "GPE3_4");
+	else
+		ret = gpio_request_one(EXYNOS4_GPE3(4),
+					GPIOF_OUT_INIT_LOW, "GPE3_4");
+
+	gpio_free(EXYNOS4_GPE3(4));
+
+	if (ret)
+		pr_err("failed to request gpio for LCD power: %d\n", ret);
+}
+
+static struct plat_lcd_data origen_lcd_hv070wsa_data = {
+	.set_power = lcd_hv070wsa_set_power,
+};
+
+static struct platform_device origen_lcd_hv070wsa = {
+	.name			= "platform-lcd",
+	.dev.parent		= &s5p_device_fimd0.dev,
+	.dev.platform_data	= &origen_lcd_hv070wsa_data,
+};
+
+static struct s3c_fb_pd_win origen_fb_win0 = {
+	.win_mode = {
+		.left_margin	= 64,
+		.right_margin	= 16,
+		.upper_margin	= 64,
+		.lower_margin	= 16,
+		.hsync_len	= 48,
+		.vsync_len	= 3,
+		.xres		= 1024,
+		.yres		= 600,
+	},
+	.max_bpp		= 32,
+	.default_bpp		= 24,
+};
+
+static struct s3c_fb_platdata origen_lcd_pdata __initdata = {
+	.win[0]		= &origen_fb_win0,
+	.vidcon0	= VIDCON0_VIDOUT_RGB | VIDCON0_PNRMODE_RGB,
+	.vidcon1	= VIDCON1_INV_HSYNC | VIDCON1_INV_VSYNC,
+	.setup_gpio	= exynos4_fimd0_gpio_setup_24bpp,
+};
+
 static struct platform_device *origen_devices[] __initdata = {
+	&exynos4_device_pd[PD_LCD0],
 	&s3c_device_hsmmc2,
 	&s3c_device_rtc,
 	&s3c_device_wdt,
+	&s5p_device_fimd0,
+	&origen_lcd_hv070wsa,
 };
 
 static void __init origen_map_io(void)
@@ -95,7 +153,9 @@ static void __init origen_map_io(void)
 static void __init origen_machine_init(void)
 {
 	s3c_sdhci2_set_platdata(&origen_hsmmc2_pdata);
+	s5p_fimd0_set_platdata(&origen_lcd_pdata);
 	platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices));
+	s5p_device_fimd0.dev.parent = &exynos4_device_pd[PD_LCD0].dev;
 }
 
 MACHINE_START(ORIGEN, "ORIGEN")
-- 
1.7.4.1

Re: [PATCH V4] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

[Wolfgang Denk]

Dear Tushar Behera,

In message <1316076867-2138-1-git-send-email-tushar.behera@linaro.org> you wrote:
> ORIGEN board is fitted with 7" LCD panel HV070WSA. The pixel
> resolution of the LCD panel is 1024x600.
...
> +static struct s3c_fb_pd_win origen_fb_win0 = {
> +	.win_mode = {
> +		.left_margin	= 64,
> +		.right_margin	= 16,
> +		.upper_margin	= 64,
> +		.lower_margin	= 16,
> +		.hsync_len	= 48,
> +		.vsync_len	= 3,
> +		.xres		= 1024,
> +		.yres		= 600,
> +	},
> +	.max_bpp		= 32,
> +	.default_bpp		= 24,
> +};

Does it still make sense to hard-code such parameters?

In PowerPC-land we pass display mode information in the device tree
using a verbatim EDID block.

Would it be not better (and way more flexible) to do the same here,
now that ARM has device tree support?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The only way to get rid of a temptation is to yield to it.
                                                        - Oscar Wilde

Re: [PATCH V4] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

[Tushar Behera]

Dear Wolfgang Denk,

On Thursday 15 September 2011 02:44 PM, Wolfgang Denk wrote:
> Dear Tushar Behera,
>
> In message<1316076867-2138-1-git-send-email-tushar.behera@linaro.org>  you wrote:
>> ORIGEN board is fitted with 7" LCD panel HV070WSA. The pixel
>> resolution of the LCD panel is 1024x600.
> ...
>> +static struct s3c_fb_pd_win origen_fb_win0 = {
>> +	.win_mode = {
>> +		.left_margin	= 64,
>> +		.right_margin	= 16,
>> +		.upper_margin	= 64,
>> +		.lower_margin	= 16,
>> +		.hsync_len	= 48,
>> +		.vsync_len	= 3,
>> +		.xres		= 1024,
>> +		.yres		= 600,
>> +	},
>> +	.max_bpp		= 32,
>> +	.default_bpp		= 24,
>> +};
>
> Does it still make sense to hard-code such parameters?
>
> In PowerPC-land we pass display mode information in the device tree
> using a verbatim EDID block.
>
> Would it be not better (and way more flexible) to do the same here,
> now that ARM has device tree support?
>
Thanks for your suggestions.

Currently work for enabling device tree support for EXYNOS4 based 
machine is going on. Once it is done, we should be able to pass this 
information through device tree blob.

For non-DT machines, IMHO, we have to follow the current approach.
> Best regards,
>
> Wolfgang Denk
>


-- 
Tushar Behera

RE: [PATCH V4] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

[Kukjin Kim]

Tushar Behera wrote:
> 
> Dear Wolfgang Denk,
> 
> On Thursday 15 September 2011 02:44 PM, Wolfgang Denk wrote:
> > Dear Tushar Behera,
> >
> > In message<1316076867-2138-1-git-send-email-tushar.behera@linaro.org>
you
> wrote:
> >> ORIGEN board is fitted with 7" LCD panel HV070WSA. The pixel
> >> resolution of the LCD panel is 1024x600.
> > ...
> >> +static struct s3c_fb_pd_win origen_fb_win0 = {
> >> +	.win_mode = {
> >> +		.left_margin	= 64,
> >> +		.right_margin	= 16,
> >> +		.upper_margin	= 64,
> >> +		.lower_margin	= 16,
> >> +		.hsync_len	= 48,
> >> +		.vsync_len	= 3,
> >> +		.xres		= 1024,
> >> +		.yres		= 600,
> >> +	},
> >> +	.max_bpp		= 32,
> >> +	.default_bpp		= 24,
> >> +};
> >
> > Does it still make sense to hard-code such parameters?
> >
> > In PowerPC-land we pass display mode information in the device tree
> > using a verbatim EDID block.
> >
> > Would it be not better (and way more flexible) to do the same here,
> > now that ARM has device tree support?
> >
> Thanks for your suggestions.
> 
> Currently work for enabling device tree support for EXYNOS4 based
> machine is going on. Once it is done, we should be able to pass this
> information through device tree blob.
> 
> For non-DT machines, IMHO, we have to follow the current approach.

OK, applied.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.