From: "Christopher J. PeBenito" <cpebenito@tresys.com>
To: Eric Paris <eparis@redhat.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>, <selinux@tycho.nsa.gov>,
<guido@trentalancia.com>
Subject: Re: [PATCH 2/2] libselinux: do not use relative path when creating libselinux symlinks
Date: Thu, 15 Sep 2011 08:01:01 -0400 [thread overview]
Message-ID: <4E71E8FD.8020505@tresys.com> (raw)
In-Reply-To: <1316031697.2738.37.camel@localhost>
On 09/14/11 16:21, Eric Paris wrote:
> On Wed, 2011-09-14 at 15:18 -0400, Stephen Smalley wrote:
>> On Wed, 2011-09-14 at 14:50 -0400, Eric Paris wrote:
>>> At the moment we create a symlink:
>>>
>>> /usr/lib/libselinux.so -> ../../lib/libselinux.so.1
>>>
>>> This works if (and only if) $SHLIBDIR and $LIBDIR are different only by
>>> ../../. Instead create a symlink from
>>>
>>> $LIBDIR/libselinux.so->$SHLIBDIR/libselinux.so.1
>>>
>>> Thus it works no matter what values one might use for LIBDIR and
>>> SHLIBDIR.
>>
>> I'm not sure this works the way you would want. Consider rpm build of
>> libselinux - it does:
>> make DESTDIR="%{buildroot}" LIBDIR="%{buildroot}%{_libdir}"
>> SHLIBDIR="%{buildroot}/%{_lib}" BINDIR="%{buildroot}%{_sbindir}" install
>>
>> And then rpm collects up the files into the package.
>> But if the symlink encodes the full pathname used at make install time,
>> then it will be wrong on the final system when the rpm is installed.
>> Haven't actually tested that theory, but I think it is true. Welcome to
>> hell.
>
> error: Symlink points to BuildRoot: /usr/lib64/libselinux.so
> -> /root/rpmbuild/BUILDROOT/libselinux-2.1.5-4.fc16.1.eparis.x86_64/lib64/libselinux.so.1
>
> GRRRRRR. Every other package I see with similar symlinks seems to be
> an autoconf package and I can't understand how they work. What we have
> isn't right, but I don't know how to fix it....
Its easy. The makefile needs to be tweaked so you don't have to specify %{buildroot} as part of the LIBDIR, SHLIBDIR, and BINDIR variables. Then when you use those variables, you prepend DESTDIR as necessary. So if you have usages like
install foo $(BINDIR)
it turns into
install foo $(DESTDIR)(BINDIR)
Then when you have your symlink you can do
ln -s $(SHLIBDIR)/bar.so.1 $(DESTDIR)$(SHLIBDIR)/bar.so
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2011-09-15 12:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 18:50 [PATCH 1/2] libselinux: put libselinux.so.1 in /lib not /usr/lib Eric Paris
2011-09-14 18:50 ` [PATCH 2/2] libselinux: do not use relative path when creating libselinux symlinks Eric Paris
2011-09-14 19:18 ` Stephen Smalley
2011-09-14 20:21 ` Eric Paris
2011-09-15 1:49 ` Guido Trentalancia
2011-09-15 12:01 ` Christopher J. PeBenito [this message]
2011-09-15 12:16 ` Guido Trentalancia
2011-09-15 12:22 ` Christopher J. PeBenito
2011-09-15 12:34 ` Guido Trentalancia
2011-09-15 12:53 ` Guido Trentalancia
2011-09-15 17:01 ` Christopher J. PeBenito
2011-09-15 17:08 ` Guido Trentalancia
2011-09-15 17:29 ` Stephen Smalley
2011-09-15 2:01 ` Guido Trentalancia
2011-09-15 1:41 ` Guido Trentalancia
2011-09-15 1:46 ` Eric Paris
2011-09-15 12:41 ` Stephen Smalley
2011-09-14 19:14 ` [PATCH 1/2] libselinux: put libselinux.so.1 in /lib not /usr/lib Eric Paris
2011-09-15 17:13 ` [PATCH] policycoreutils: fix sandbox Makefile Stephen Smalley
2011-09-15 17:38 ` Guido Trentalancia
2011-09-15 17:50 ` Stephen Smalley
2011-09-15 18:15 ` Guido Trentalancia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E71E8FD.8020505@tresys.com \
--to=cpebenito@tresys.com \
--cc=eparis@redhat.com \
--cc=guido@trentalancia.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.