From: Guido Trentalancia <guido@trentalancia.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Eric Paris <eparis@parisplace.org>,
Eric Paris <eparis@redhat.com>,
selinux@tycho.nsa.gov
Subject: Re: [PATCH] policycoreutils: fix sandbox Makefile
Date: Thu, 15 Sep 2011 19:38:52 +0200 [thread overview]
Message-ID: <1316108332.2202.49.camel@vortex> (raw)
In-Reply-To: <1316106835.16483.32.camel@moss-pluto>
On Thu, 2011-09-15 at 13:13 -0400, Stephen Smalley wrote:
> Fix sandbox Makefile so that make DESTDIR=~/out install works again.
>
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
>
> ---
>
> policycoreutils/sandbox/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/policycoreutils/sandbox/Makefile b/policycoreutils/sandbox/Makefile
> index 21df0c4..4566810 100644
> --- a/policycoreutils/sandbox/Makefile
> +++ b/policycoreutils/sandbox/Makefile
> @@ -2,6 +2,7 @@
> PREFIX ?= ${DESTDIR}/usr
> INITDIR ?= ${DESTDIR}/etc/rc.d/init.d/
> SYSCONFDIR ?= ${DESTDIR}/etc/sysconfig
> +LIBDIR ?= $(PREFIX)/lib
> BINDIR ?= $(PREFIX)/bin
> SBINDIR ?= $(PREFIX)/sbin
> MANDIR ?= $(PREFIX)/share/man
> @@ -13,7 +14,7 @@ LDLIBS += -lselinux -lcap-ng
> all: sandbox seunshare sandboxX.sh start
>
> seunshare: seunshare.o $(EXTRA_OBJS)
> - $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS)
> + $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) -L$(LIBDIR)
EXTRA_OBJS is not defined therefore it is empty unless passed from the
command-line...
Perhaps you meant the -L flag goes before the LDLIBS (which is made just
of -l flags) ?
as in:
- $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS)
+ $(CC) $(LDFLAGS) -o $@ $^ -L$(LIBDIR) $(LDLIBS)
> install: all
> -mkdir -p $(BINDIR)
>
Guido
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2011-09-15 17:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 18:50 [PATCH 1/2] libselinux: put libselinux.so.1 in /lib not /usr/lib Eric Paris
2011-09-14 18:50 ` [PATCH 2/2] libselinux: do not use relative path when creating libselinux symlinks Eric Paris
2011-09-14 19:18 ` Stephen Smalley
2011-09-14 20:21 ` Eric Paris
2011-09-15 1:49 ` Guido Trentalancia
2011-09-15 12:01 ` Christopher J. PeBenito
2011-09-15 12:16 ` Guido Trentalancia
2011-09-15 12:22 ` Christopher J. PeBenito
2011-09-15 12:34 ` Guido Trentalancia
2011-09-15 12:53 ` Guido Trentalancia
2011-09-15 17:01 ` Christopher J. PeBenito
2011-09-15 17:08 ` Guido Trentalancia
2011-09-15 17:29 ` Stephen Smalley
2011-09-15 2:01 ` Guido Trentalancia
2011-09-15 1:41 ` Guido Trentalancia
2011-09-15 1:46 ` Eric Paris
2011-09-15 12:41 ` Stephen Smalley
2011-09-14 19:14 ` [PATCH 1/2] libselinux: put libselinux.so.1 in /lib not /usr/lib Eric Paris
2011-09-15 17:13 ` [PATCH] policycoreutils: fix sandbox Makefile Stephen Smalley
2011-09-15 17:38 ` Guido Trentalancia [this message]
2011-09-15 17:50 ` Stephen Smalley
2011-09-15 18:15 ` Guido Trentalancia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316108332.2202.49.camel@vortex \
--to=guido@trentalancia.com \
--cc=eparis@parisplace.org \
--cc=eparis@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.