All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nitin Gupta <ngupta@vflare.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Greg KH <greg@kroah.com>,
	gregkh@suse.de, devel@driverdev.osuosl.org,
	cascardo@holoscopio.com, linux-kernel@vger.kernel.org,
	dave@linux.vnet.ibm.com, linux-mm@kvack.org,
	brking@linux.vnet.ibm.com, rcj@linux.vnet.ibm.com
Subject: Re: [PATCH v2 0/3] staging: zcache: xcfmalloc support
Date: Fri, 16 Sep 2011 13:52:54 -0400	[thread overview]
Message-ID: <4E738CF6.4020808@vflare.org> (raw)
In-Reply-To: <4E725109.3010609@linux.vnet.ibm.com>

On 09/15/2011 03:24 PM, Seth Jennings wrote:

> On 09/15/2011 12:29 PM, Dan Magenheimer wrote:
>>> From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com]
>>> Subject: Re: [PATCH v2 0/3] staging: zcache: xcfmalloc support
>>>


>>
>> Seth, I am still not clear why it is not possible to support
>> either allocation algorithm, selectable at runtime.  Or even
>> dynamically... use xvmalloc to store well-compressible pages
>> and xcfmalloc for poorly-compressible pages.  I understand
>> it might require some additional coding, perhaps even an
>> ugly hack or two, but it seems possible.
> 
> But why do an ugly hack if we can just use a single allocator
> that has the best overall performance for the allocation range
> the zcache requires.  Why make it more complicated that it
> needs to be?
> 
>>


I agree with Seth here: a mix of different allocators for the (small)
range of sizes which zcache requires, looks like a bad idea to me.
Maintaining two allocators is a pain and this will also complicate
future plans like compaction etc.

Thanks,
Nitin


WARNING: multiple messages have this Message-ID (diff)
From: Nitin Gupta <ngupta@vflare.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Greg KH <greg@kroah.com>,
	gregkh@suse.de, devel@driverdev.osuosl.org,
	cascardo@holoscopio.com, linux-kernel@vger.kernel.org,
	dave@linux.vnet.ibm.com, linux-mm@kvack.org,
	brking@linux.vnet.ibm.com, rcj@linux.vnet.ibm.com
Subject: Re: [PATCH v2 0/3] staging: zcache: xcfmalloc support
Date: Fri, 16 Sep 2011 13:52:54 -0400	[thread overview]
Message-ID: <4E738CF6.4020808@vflare.org> (raw)
In-Reply-To: <4E725109.3010609@linux.vnet.ibm.com>

On 09/15/2011 03:24 PM, Seth Jennings wrote:

> On 09/15/2011 12:29 PM, Dan Magenheimer wrote:
>>> From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com]
>>> Subject: Re: [PATCH v2 0/3] staging: zcache: xcfmalloc support
>>>


>>
>> Seth, I am still not clear why it is not possible to support
>> either allocation algorithm, selectable at runtime.  Or even
>> dynamically... use xvmalloc to store well-compressible pages
>> and xcfmalloc for poorly-compressible pages.  I understand
>> it might require some additional coding, perhaps even an
>> ugly hack or two, but it seems possible.
> 
> But why do an ugly hack if we can just use a single allocator
> that has the best overall performance for the allocation range
> the zcache requires.  Why make it more complicated that it
> needs to be?
> 
>>


I agree with Seth here: a mix of different allocators for the (small)
range of sizes which zcache requires, looks like a bad idea to me.
Maintaining two allocators is a pain and this will also complicate
future plans like compaction etc.

Thanks,
Nitin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-09-16 17:53 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 14:09 [PATCH v2 0/3] staging: zcache: xcfmalloc support Seth Jennings
2011-09-07 14:09 ` Seth Jennings
2011-09-07 14:09 ` [PATCH v2 1/3] staging: zcache: xcfmalloc memory allocator for zcache Seth Jennings
2011-09-07 14:09   ` Seth Jennings
2011-09-07 14:09 ` [PATCH v2 2/3] staging: zcache: replace xvmalloc with xcfmalloc Seth Jennings
2011-09-07 14:09   ` Seth Jennings
2011-09-07 14:09 ` [PATCH v2 3/3] staging: zcache: add zv_page_count and zv_desc_count Seth Jennings
2011-09-07 14:09   ` Seth Jennings
2011-09-09 20:34 ` [PATCH v2 0/3] staging: zcache: xcfmalloc support Greg KH
2011-09-09 20:34   ` Greg KH
2011-09-10  2:41   ` Nitin Gupta
2011-09-10  2:41     ` Nitin Gupta
2011-09-12 14:35     ` Seth Jennings
2011-09-12 14:35       ` Seth Jennings
2011-09-13  1:55       ` Nitin Gupta
2011-09-13  1:55         ` Nitin Gupta
2011-09-13 15:58         ` Seth Jennings
2011-09-13 15:58           ` Seth Jennings
2011-09-13 21:18           ` Nitin Gupta
2011-09-13 21:18             ` Nitin Gupta
2011-09-15 16:31             ` Seth Jennings
2011-09-15 16:31               ` Seth Jennings
2011-09-15 17:29               ` Dan Magenheimer
2011-09-15 17:29                 ` Dan Magenheimer
2011-09-15 19:24                 ` Seth Jennings
2011-09-15 19:24                   ` Seth Jennings
2011-09-15 20:07                   ` Dan Magenheimer
2011-09-15 20:07                     ` Dan Magenheimer
2011-10-03 15:59                     ` Dave Hansen
2011-10-03 15:59                       ` Dave Hansen
2011-10-03 17:54                       ` Nitin Gupta
2011-10-03 17:54                         ` Nitin Gupta
2011-10-03 18:22                         ` Dave Hansen
2011-10-03 18:22                           ` Dave Hansen
2011-10-05  1:03                           ` Dan Magenheimer
2011-10-05  1:03                             ` Dan Magenheimer
2011-09-15 22:17                   ` Dave Hansen
2011-09-15 22:17                     ` Dave Hansen
2011-09-15 22:27                     ` Dan Magenheimer
2011-09-15 22:27                       ` Dan Magenheimer
2011-09-16 17:36                     ` Nitin Gupta
2011-09-16 17:36                       ` Nitin Gupta
2011-09-16 17:52                   ` Nitin Gupta [this message]
2011-09-16 17:52                     ` Nitin Gupta
2011-09-16 17:46               ` Nitin Gupta
2011-09-16 17:46                 ` Nitin Gupta
2011-09-16 18:33                 ` Seth Jennings
2011-09-16 18:33                   ` Seth Jennings
2011-11-01 17:30                 ` Dave Hansen
2011-11-01 17:30                   ` Dave Hansen
2011-11-01 18:35                   ` Dan Magenheimer
2011-11-01 18:35                     ` Dan Magenheimer
2011-11-02  2:42                     ` Nitin Gupta
2011-11-02  2:42                       ` Nitin Gupta
2011-09-29 17:47 ` Seth Jennings
2011-09-29 17:47   ` Seth Jennings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E738CF6.4020808@vflare.org \
    --to=ngupta@vflare.org \
    --cc=brking@linux.vnet.ibm.com \
    --cc=cascardo@holoscopio.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.