Re: [Qemu-devel] [PATCH] sun4u: don't set up isa_mem_base

[Avi Kivity <avi@redhat.com>]

On 09/17/2011 10:28 PM, Blue Swirl wrote:
> Since we use memory API in sun4u.c, after
> 71579cae30b53c910cd6c47ab4e683f647d36519, setting up isa_mem_base
> puts vga.chain4 outside of the physical address space.
>
> Fix by removing obsolete isa_mem_base set up.
>
> Signed-off-by: Blue Swirl<blauwirbel@gmail.com>
> ---
>   hw/sun4u.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/sun4u.c b/hw/sun4u.c
> index 32e6ab9..6afb0e7 100644
> --- a/hw/sun4u.c
> +++ b/hw/sun4u.c
> @@ -763,7 +763,6 @@ static void sun4uv_init(ram_addr_t RAM_size,
>       irq = qemu_allocate_irqs(cpu_set_irq, env, MAX_PILS);
>       pci_bus = pci_apb_init(APB_SPECIAL_BASE, APB_MEM_BASE, irq,&pci_bus2,
>                              &pci_bus3);
> -    isa_mem_base = APB_PCI_IO_BASE;
>       pci_vga_init(pci_bus);

Good catch, I wonder how many more such cases remain.

I guess we should prioritize their conversion.

-- 
error compiling committee.c: too many arguments to function