Re: [PATCH 1/2] ARM: EXYNOS4: Add TVOUT support for SMDKV310

[Tomasz Stanislawski <t.stanislaws@samsung.com>]

Hi Hatim Ali,

On 08/26/2011 08:39 AM, Hatim Ali wrote:
> Add support for TVOUT on SMDKV310 board.
>
> Signed-off-by: Hatim Ali<hatim.rv@samsung.com>
> ---
>   arch/arm/mach-exynos4/Kconfig         |    2 ++
>   arch/arm/mach-exynos4/mach-smdkv310.c |    5 +++++
>   2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
> index e6925de..4c399c0 100644
> --- a/arch/arm/mach-exynos4/Kconfig
> +++ b/arch/arm/mach-exynos4/Kconfig
> @@ -139,6 +139,7 @@ config MACH_SMDKV310
>   	select S3C_DEV_RTC
>   	select S3C_DEV_WDT
>   	select S3C_DEV_I2C1
> +	select S5P_DEV_I2C_HDMIPHY
>   	select S5P_DEV_MFC
>   	select S3C_DEV_HSMMC
>   	select S3C_DEV_HSMMC1
> @@ -148,6 +149,7 @@ config MACH_SMDKV310
>   	select EXYNOS4_DEV_AHCI
>   	select SAMSUNG_DEV_KEYPAD
>   	select EXYNOS4_DEV_PD
> +	select S5P_DEV_TV
>   	select SAMSUNG_DEV_PWM
>   	select EXYNOS4_DEV_SYSMMU
>   	select EXYNOS4_SETUP_FIMD0
> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c
> index 5f62b2b..8fdba16 100644
> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
> @@ -173,6 +173,7 @@ static struct platform_device *smdkv310_devices[] __initdata = {
>   	&s3c_device_hsmmc2,
>   	&s3c_device_hsmmc3,
>   	&s3c_device_i2c1,
> +	&s5p_device_i2c_hdmiphy,
>   	&s3c_device_rtc,
>   	&s3c_device_wdt,
>   	&exynos4_device_ac97,
> @@ -194,6 +195,8 @@ static struct platform_device *smdkv310_devices[] __initdata = {
>   	&samsung_asoc_idma,
>   	&smdkv310_smsc911x,
>   	&exynos4_device_ahci,
> +	&s5p_device_hdmi,
> +	&s5p_device_mixer,
I should add TV power domain device exynos4_device_pd[PD_TV]  here.
>   };
>
>   static void __init smdkv310_smsc911x_init(void)
> @@ -254,6 +257,8 @@ static void __init smdkv310_machine_init(void)
>   	s3c_sdhci2_set_platdata(&smdkv310_hsmmc2_pdata);
>   	s3c_sdhci3_set_platdata(&smdkv310_hsmmc3_pdata);
>
> +	s5p_i2c_hdmiphy_set_platdata(NULL);
> +
You should set mixer's and hdmi's parents here to device for TV power 
domain.
You should also configure gpio for hot-plug detection. Please refer to 
function s5p_tv_setup
in arch/arm/mach-exynos4/mach-universal_c210.c:1012.
>   	samsung_keypad_set_platdata(&smdkv310_keypad_data);
>
>   	samsung_bl_set(&smdkv310_bl_gpio_info,&smdkv310_bl_data);
I hope you find this information useful.

Best regards,
Tomasz Stanislawski