From: Rik van Riel <riel@redhat.com>
To: Michel Lespinasse <walken@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Johannes Weiner <jweiner@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Hugh Dickins <hughd@google.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Wolf <mjwolf@us.ibm.com>
Subject: Re: [PATCH 1/8] page_referenced: replace vm_flags parameter with struct pr_info
Date: Tue, 20 Sep 2011 15:05:03 -0400 [thread overview]
Message-ID: <4E78E3DF.1070501@redhat.com> (raw)
In-Reply-To: <1316230753-8693-2-git-send-email-walken@google.com>
On 09/16/2011 11:39 PM, Michel Lespinasse wrote:
> Introduce struct pr_info, passed into page_referenced() family of functions,
> to represent information about the pte references that have been found for
> that page. Currently contains the vm_flags information as well as
> a PR_REFERENCED flag. The idea is to make it easy to extend the API
> with new flags.
>
>
> Signed-off-by: Michel Lespinasse<walken@google.com>
I have to agree with Joe's suggested name change.
Other than that, this patch looks good (will ack the next version).
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Michel Lespinasse <walken@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Johannes Weiner <jweiner@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Hugh Dickins <hughd@google.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Wolf <mjwolf@us.ibm.com>
Subject: Re: [PATCH 1/8] page_referenced: replace vm_flags parameter with struct pr_info
Date: Tue, 20 Sep 2011 15:05:03 -0400 [thread overview]
Message-ID: <4E78E3DF.1070501@redhat.com> (raw)
In-Reply-To: <1316230753-8693-2-git-send-email-walken@google.com>
On 09/16/2011 11:39 PM, Michel Lespinasse wrote:
> Introduce struct pr_info, passed into page_referenced() family of functions,
> to represent information about the pte references that have been found for
> that page. Currently contains the vm_flags information as well as
> a PR_REFERENCED flag. The idea is to make it easy to extend the API
> with new flags.
>
>
> Signed-off-by: Michel Lespinasse<walken@google.com>
I have to agree with Joe's suggested name change.
Other than that, this patch looks good (will ack the next version).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-20 19:05 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-17 3:39 [PATCH 0/8] idle page tracking / working set estimation Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-17 3:39 ` [PATCH 1/8] page_referenced: replace vm_flags parameter with struct pr_info Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-17 3:44 ` Joe Perches
2011-09-17 3:44 ` Joe Perches
2011-09-17 4:51 ` Michel Lespinasse
2011-09-17 4:51 ` Michel Lespinasse
2011-09-20 19:05 ` Rik van Riel [this message]
2011-09-20 19:05 ` Rik van Riel
2011-09-21 2:51 ` Michel Lespinasse
2011-09-21 2:51 ` Michel Lespinasse
2011-09-17 3:39 ` [PATCH 2/8] kstaled: documentation and config option Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-20 21:23 ` Rik van Riel
2011-09-20 21:23 ` Rik van Riel
2011-09-23 19:27 ` Rik van Riel
2011-09-23 19:27 ` Rik van Riel
2011-09-17 3:39 ` [PATCH 3/8] kstaled: page_referenced_kstaled() and supporting infrastructure Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-20 19:36 ` Peter Zijlstra
2011-09-20 19:36 ` Peter Zijlstra
2011-09-17 3:39 ` [PATCH 4/8] kstaled: minimalistic implementation Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-22 23:14 ` Andrew Morton
2011-09-22 23:14 ` Andrew Morton
2011-09-23 8:37 ` Michel Lespinasse
2011-09-23 8:37 ` Michel Lespinasse
2011-09-17 3:39 ` [PATCH 5/8] kstaled: skip non-RAM regions Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-17 3:39 ` [PATCH 6/8] kstaled: rate limit pages scanned per second Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-22 23:15 ` Andrew Morton
2011-09-22 23:15 ` Andrew Morton
2011-09-23 10:18 ` Michel Lespinasse
2011-09-23 10:18 ` Michel Lespinasse
2011-09-17 3:39 ` [PATCH 7/8] kstaled: add histogram sampling functionality Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-22 23:15 ` Andrew Morton
2011-09-22 23:15 ` Andrew Morton
2011-09-23 10:26 ` Michel Lespinasse
2011-09-23 10:26 ` Michel Lespinasse
2011-09-17 3:39 ` [PATCH 8/8] kstaled: add incrementally updating stale page count Michel Lespinasse
2011-09-17 3:39 ` Michel Lespinasse
2011-09-22 23:13 ` [PATCH 0/8] idle page tracking / working set estimation Andrew Morton
2011-09-22 23:13 ` Andrew Morton
2011-09-23 1:23 ` Michel Lespinasse
2011-09-23 1:23 ` Michel Lespinasse
2011-09-27 10:03 ` Balbir Singh
2011-09-27 10:03 ` Balbir Singh
2011-09-27 10:14 ` Michel Lespinasse
2011-09-27 10:14 ` Michel Lespinasse
2011-09-27 16:50 ` Balbir Singh
2011-09-27 16:50 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E78E3DF.1070501@redhat.com \
--to=riel@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjwolf@us.ibm.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.