From: Randy Dunlap <rdunlap@xenotime.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH -next] bcma: needs export.h
Date: Tue, 20 Sep 2011 13:43:18 -0700 [thread overview]
Message-ID: <4E78FAE6.6080903@xenotime.net> (raw)
In-Reply-To: <CACna6rxGrd-ORWZrc0xsAOKptU_Xj3eGh9qSfX9vJYCPTZrCRg@mail.gmail.com>
On 09/20/2011 11:45 AM, Rafał Miłecki wrote:
> 2011/9/20 Randy Dunlap <rdunlap@xenotime.net>:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> bcma/driver_chipcommon_pmu.c needs to include <linux/export.h>,
>> so add it to the headers that are included by bcma_private.h.
>
> Please take a look at discussion in:
> [PATCH -next] bcma: main.c needs to include <linux/slab.h>
> thread (by Andrew).
>
> I believe that according to the discussion, such a includes should be
> done in .c files.
>
> Andrew: can you comment? Am I right?
Sure, I'll resubmit the patch.
Is there already a patch to remove <linux/delay.h> from bcma_private.h ?
bcma_private.h uses __init & __exit, so it should #include <linux/init.h> ...
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-09-20 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 7:31 linux-next: Tree for Sept 20 Stephen Rothwell
2011-09-20 17:39 ` [PATCH -next] bcma: needs export.h Randy Dunlap
2011-09-20 18:45 ` Rafał Miłecki
2011-09-20 20:43 ` Randy Dunlap [this message]
2011-09-20 20:51 ` [PATCH -next v2] bcma: driver_chipcommon_pmu.c needs linux/export.h Randy Dunlap
2011-09-20 21:11 ` Stephen Rothwell
2011-09-21 6:45 ` Rafał Miłecki
2011-09-21 15:52 ` Randy Dunlap
2011-09-21 18:00 ` Rafał Miłecki
2011-09-21 21:07 ` [PATCH -next] bcma: main.c and driver_mips.c need linux/export.h Randy Dunlap
2011-09-21 21:42 ` Larry Finger
2011-09-21 21:49 ` Randy Dunlap
2011-09-20 22:40 ` [PATCH -next] bcma: needs export.h Andrew Morton
2011-09-20 20:39 ` linux-next: Tree for Sept 20 (llc/psnap/p8022) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E78FAE6.6080903@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.