From: Randy Dunlap <rdunlap@xenotime.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>
Subject: Re: [PATCH -next] bcma: main.c and driver_mips.c need linux/export.h
Date: Wed, 21 Sep 2011 14:49:06 -0700 [thread overview]
Message-ID: <4E7A5BD2.40502@xenotime.net> (raw)
In-Reply-To: <4E7A5A2F.7030402@lwfinger.net>
On 09/21/2011 02:42 PM, Larry Finger wrote:
> On 09/21/2011 04:07 PM, Randy Dunlap wrote:
>> From: Randy Dunlap<rdunlap@xenotime.net>
>>
>> main.c and driver_mips.c use EXPORT_SYMBOL() etc.
>> so they should include<linux/export.h>.
>>
>> Signed-off-by: Randy Dunlap<rdunlap@xenotime.net>
>
> From this commit message, it appears that every routine that uses EXPORT_SYMBOL() will need to include this header. I looked at modifying rtlwifi and friends to include this header, but found that include/linux/export.h does not exist in any of my source trees. From that I assume that the change will happen in 3.2.
>
> I have prepared a patch, but cannot use it at the moment. Is there somewhere that I should send it?
Hi Larry,
linux/export.h is only in linux-next. I think that you should just prepare
a linux-next patch for rtlwifi and then push it after Paul Gortmaker's
module.h-split git tree has been merged (it splits module.h into module.h
and export.h), or maybe you could ask Paul to merge your patch into his tree.
[I added Paul to the cc: list.]
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-09-21 21:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 7:31 linux-next: Tree for Sept 20 Stephen Rothwell
2011-09-20 17:39 ` [PATCH -next] bcma: needs export.h Randy Dunlap
2011-09-20 18:45 ` Rafał Miłecki
2011-09-20 20:43 ` Randy Dunlap
2011-09-20 20:51 ` [PATCH -next v2] bcma: driver_chipcommon_pmu.c needs linux/export.h Randy Dunlap
2011-09-20 21:11 ` Stephen Rothwell
2011-09-21 6:45 ` Rafał Miłecki
2011-09-21 15:52 ` Randy Dunlap
2011-09-21 18:00 ` Rafał Miłecki
2011-09-21 21:07 ` [PATCH -next] bcma: main.c and driver_mips.c need linux/export.h Randy Dunlap
2011-09-21 21:42 ` Larry Finger
2011-09-21 21:49 ` Randy Dunlap [this message]
2011-09-20 22:40 ` [PATCH -next] bcma: needs export.h Andrew Morton
2011-09-20 20:39 ` linux-next: Tree for Sept 20 (llc/psnap/p8022) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7A5BD2.40502@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sfr@canb.auug.org.au \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.