Re: [Qemu-devel] [PATCH 1/2] trace: Add "vcpu_init" event

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2011-09-20 21:06, Lluís Vilanova wrote:
> Signals the creation of a new vCPU (CPUState structure).
> 
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  cpus.c        |    1 +
>  qemu-common.h |    4 +++-
>  trace-events  |    7 +++++++
>  3 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/cpus.c b/cpus.c
> index 54c188c..ab699bb 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -861,6 +861,7 @@ void qemu_init_vcpu(void *_env)
>      } else {
>          qemu_tcg_init_vcpu(env);
>      }
> +    trace_vcpu_init(env);
>  }
>  
>  void qemu_notify_event(void)
> diff --git a/qemu-common.h b/qemu-common.h
> index 404c421..511f0c7 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -296,8 +296,10 @@ struct qemu_work_item {
>      int done;
>  };
>  
> +#include "trace.h"
> +
>  #ifdef CONFIG_USER_ONLY
> -#define qemu_init_vcpu(env) do { } while (0)
> +#define qemu_init_vcpu(env) do { trace_vcpu_init(env); } while (0)

As you are already at it, please make this a proper static inline
instead of a macro.

Both patches look good otherwise.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux