From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Hatim Ali <hatim.rv@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
t.stanislaws@samsung.com, mchehab@infradead.org,
hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
banajit.g@samsung.com
Subject: Re: [PATCH V2 1/3] ARM: EXYNOS4: Add TVOUT support for SMDKV310
Date: Wed, 21 Sep 2011 15:05:38 +0200 [thread overview]
Message-ID: <4E79E122.2000600@samsung.com> (raw)
In-Reply-To: <1316583860-32510-2-git-send-email-hatim.rv@samsung.com>
Hi Hatim,
On 09/21/2011 07:44 AM, Hatim Ali wrote:
> Add support for TVOUT on SMDKV310 board.
>
> Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
> ---
...
> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c
> index 7ce4d8b..50de270 100644
> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
> @@ -239,6 +239,7 @@ static struct platform_device *smdkv310_devices[] __initdata = {
> &s3c_device_hsmmc2,
> &s3c_device_hsmmc3,
> &s3c_device_i2c1,
> + &s5p_device_i2c_hdmiphy,
> &s3c_device_rtc,
> &s3c_device_wdt,
> &exynos4_device_ac97,
> @@ -262,6 +263,8 @@ static struct platform_device *smdkv310_devices[] __initdata = {
> &smdkv310_lcd_lte480wv,
> &smdkv310_smsc911x,
> &exynos4_device_ahci,
> + &s5p_device_hdmi,
> + &s5p_device_mixer,
> };
>
> static void __init smdkv310_smsc911x_init(void)
> @@ -298,6 +301,25 @@ static struct platform_pwm_backlight_data smdkv310_bl_data = {
> .pwm_period_ns = 1000,
> };
>
> +static void s5p_tv_setup(void)
> +{
> + int ret;
> +
> + /* direct HPD to HDMI chip */
> + ret = gpio_request(EXYNOS4_GPX3(7), "hpd-plug");
> +
> + if (!ret) {
> + gpio_direction_input(EXYNOS4_GPX3(7));
Since you're probably going to be reworking this anyway, I think gpio_request_one
could be used here for simplicity.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/3] ARM: EXYNOS4: Add TVOUT support for SMDKV310
Date: Wed, 21 Sep 2011 15:05:38 +0200 [thread overview]
Message-ID: <4E79E122.2000600@samsung.com> (raw)
In-Reply-To: <1316583860-32510-2-git-send-email-hatim.rv@samsung.com>
Hi Hatim,
On 09/21/2011 07:44 AM, Hatim Ali wrote:
> Add support for TVOUT on SMDKV310 board.
>
> Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
> ---
...
> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c
> index 7ce4d8b..50de270 100644
> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
> @@ -239,6 +239,7 @@ static struct platform_device *smdkv310_devices[] __initdata = {
> &s3c_device_hsmmc2,
> &s3c_device_hsmmc3,
> &s3c_device_i2c1,
> + &s5p_device_i2c_hdmiphy,
> &s3c_device_rtc,
> &s3c_device_wdt,
> &exynos4_device_ac97,
> @@ -262,6 +263,8 @@ static struct platform_device *smdkv310_devices[] __initdata = {
> &smdkv310_lcd_lte480wv,
> &smdkv310_smsc911x,
> &exynos4_device_ahci,
> + &s5p_device_hdmi,
> + &s5p_device_mixer,
> };
>
> static void __init smdkv310_smsc911x_init(void)
> @@ -298,6 +301,25 @@ static struct platform_pwm_backlight_data smdkv310_bl_data = {
> .pwm_period_ns = 1000,
> };
>
> +static void s5p_tv_setup(void)
> +{
> + int ret;
> +
> + /* direct HPD to HDMI chip */
> + ret = gpio_request(EXYNOS4_GPX3(7), "hpd-plug");
> +
> + if (!ret) {
> + gpio_direction_input(EXYNOS4_GPX3(7));
Since you're probably going to be reworking this anyway, I think gpio_request_one
could be used here for simplicity.
--
Regards,
Sylwester
next prev parent reply other threads:[~2011-09-21 13:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 5:44 [PATCH V2 0/3] Add TVOUT support for SMDKV310 Hatim Ali
2011-09-21 5:44 ` Hatim Ali
2011-09-21 5:44 ` [PATCH V2 1/3] ARM: EXYNOS4: " Hatim Ali
2011-09-21 5:44 ` Hatim Ali
2011-09-21 12:06 ` Kukjin Kim
2011-09-21 12:06 ` Kukjin Kim
2011-09-21 12:44 ` Tomasz Stanislawski
2011-09-21 12:44 ` Tomasz Stanislawski
2011-09-21 13:46 ` Hatim R.V.
2011-09-21 13:46 ` Hatim R.V.
2011-09-21 13:05 ` Sylwester Nawrocki [this message]
2011-09-21 13:05 ` Sylwester Nawrocki
2011-09-21 13:48 ` Hatim R.V.
2011-09-21 13:48 ` Hatim R.V.
2011-09-21 5:44 ` [RESEND PATCH 2/3] ARM: EXYNOS4: Update consistent DMA size to 8MB Hatim Ali
2011-09-21 5:44 ` Hatim Ali
2011-09-21 6:25 ` Kyungmin Park
2011-09-21 6:25 ` Kyungmin Park
2011-09-21 11:57 ` Kukjin Kim
2011-09-21 11:57 ` Kukjin Kim
2011-09-21 5:44 ` [RESEND PATCH 3/3] s5p-tv: Add PM_RUNTIME dependency Hatim Ali
2011-09-21 5:44 ` Hatim Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E79E122.2000600@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=banajit.g@samsung.com \
--cc=hatim.rv@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=kgene.kim@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.