All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: nick@bytemark.co.uk
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] block/curl: Remedy a crashing bug completing AIOCBs from cache
Date: Wed, 21 Sep 2011 15:32:08 +0200	[thread overview]
Message-ID: <4E79E758.9000509@redhat.com> (raw)
In-Reply-To: <1316602550-13597-1-git-send-email-nick@bytemark.co.uk>

Am 21.09.2011 12:55, schrieb nick@bytemark.co.uk:
> In QEMU master, attempting to read a cached block from a HTTP (or otherwise)
> mounted ISO causes an assert to be triggered, killing the entire QEMU process.
> It looks like this:
> 
> hw/ide/pci.c:314: bmdma_cmd_writeb: Assertion `bm->bus->dma->aiocb == 
> ((void *)0)' failed.
> 
> The following two patches add flush capability to the curl backend, and avoid
> triggering the assert by finishing the AIOCB in a QEMUBH callback, rather than
> directly in curl_aio_readv().

Thanks, applied to the block branch.

Kevin


WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: nick@bytemark.co.uk
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] block/curl: Remedy a crashing bug completing AIOCBs from cache
Date: Wed, 21 Sep 2011 15:32:08 +0200	[thread overview]
Message-ID: <4E79E758.9000509@redhat.com> (raw)
In-Reply-To: <1316602550-13597-1-git-send-email-nick@bytemark.co.uk>

Am 21.09.2011 12:55, schrieb nick@bytemark.co.uk:
> In QEMU master, attempting to read a cached block from a HTTP (or otherwise)
> mounted ISO causes an assert to be triggered, killing the entire QEMU process.
> It looks like this:
> 
> hw/ide/pci.c:314: bmdma_cmd_writeb: Assertion `bm->bus->dma->aiocb == 
> ((void *)0)' failed.
> 
> The following two patches add flush capability to the curl backend, and avoid
> triggering the assert by finishing the AIOCB in a QEMUBH callback, rather than
> directly in curl_aio_readv().

Thanks, applied to the block branch.

Kevin

  parent reply	other threads:[~2011-09-21 13:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21 10:55 [Qemu-trivial] block/curl: Remedy a crashing bug completing AIOCBs from cache nick
2011-09-21 10:55 ` [Qemu-devel] " nick
2011-09-21 10:55 ` [Qemu-trivial] [PATCH 1/2] block/curl: Implement a flush function on the fd handlers nick
2011-09-21 10:55   ` [Qemu-devel] " nick
2011-09-21 10:55 ` [Qemu-trivial] [PATCH 2/2] block/curl: Don't finish AIOCBs too early nick
2011-09-21 10:55   ` [Qemu-devel] " nick
2011-09-21 13:32 ` Kevin Wolf [this message]
2011-09-21 13:32   ` [Qemu-devel] block/curl: Remedy a crashing bug completing AIOCBs from cache Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E79E758.9000509@redhat.com \
    --to=kwolf@redhat.com \
    --cc=nick@bytemark.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.