[Qemu-devel] [PULL 0/8] Trivial patches for September 10 to 21 2011

[Qemu-devel] [PULL 0/8] Trivial patches for September 10 to 21 2011

[Stefan Hajnoczi]

The following changes since commit 27cdad67a1bc23b38c765b677ed8064bfb8d3e44:

  Revert "alpha-softmmu: Disable for the 0.15 release branch." (2011-09-21 00:50:32 +0200)

are available in the git repository at:
  ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches

Christoph Egger (1):
      use qemu_* ctype functions

Jan Kiszka (3):
      Drop unneeded pthread.h inclusions
      Silence make if nothing is to do for libcacard
      Abort on thread layer errors

Paolo Bonzini (1):
      fix compilation with stderr trace backend

Peter Maydell (1):
      configure: Make missing pkg-config an error rather than a warning

Stefan Weil (2):
      target-i386: Remove data type CCTable
      Remove qemu_host_page_bits

 cmd.c                   |    2 +-
 configure               |    4 ++--
 cpu-all.h               |    1 -
 exec.c                  |    4 ----
 hw/xen_nic.c            |    1 -
 hw/xics.c               |    2 --
 libcacard/Makefile      |    2 ++
 qemu-thread-posix.c     |    2 +-
 qemu-thread-win32.c     |    2 +-
 target-i386/cpu.h       |    5 -----
 target-i386/translate.c |    5 -----
 trace-events            |    2 +-
 ui/keymaps.c            |    2 +-
 ui/spice-display.c      |    2 --
 14 files changed, 9 insertions(+), 27 deletions(-)

-- 
1.7.5.4

[Qemu-devel] [PATCH 1/8] target-i386: Remove data type CCTable

[Stefan Hajnoczi]

From: Stefan Weil <weil@mail.berlios.de>

Remove also two assert statements which were the last remaining users.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 target-i386/cpu.h       |    5 -----
 target-i386/translate.c |    5 -----
 2 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 4a6f675..ae36489 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -991,11 +991,6 @@ static inline int cpu_mmu_index (CPUState *env)
 /* translate.c */
 void optimize_flags_init(void);
 
-typedef struct CCTable {
-    int (*compute_all)(void); /* return all the flags */
-    int (*compute_c)(void);  /* return the C flag */
-} CCTable;
-
 #if defined(CONFIG_USER_ONLY)
 static inline void cpu_clone_regs(CPUState *env, target_ulong newsp)
 {
diff --git a/target-i386/translate.c b/target-i386/translate.c
index b966762..b894e97 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -7641,11 +7641,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
 
 void optimize_flags_init(void)
 {
-#if TCG_TARGET_REG_BITS == 32
-    assert(sizeof(CCTable) == (1 << 3));
-#else
-    assert(sizeof(CCTable) == (1 << 4));
-#endif
     cpu_env = tcg_global_reg_new_ptr(TCG_AREG0, "env");
     cpu_cc_op = tcg_global_mem_new_i32(TCG_AREG0,
                                        offsetof(CPUState, cc_op), "cc_op");
-- 
1.7.5.4

[Qemu-devel] [PATCH 2/8] configure: Make missing pkg-config an error rather than a warning

[Stefan Hajnoczi]

From: Peter Maydell <peter.maydell@linaro.org>

If pkg-config doesn't exist then make configure fail immediately
with a useful error message. Now that glib is a required dependency,
proceeding despite the missing pkg-config will just cause us to
fail later with a misleading message about glib not being present.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 configure |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 414317a..9ab3ab4 100755
--- a/configure
+++ b/configure
@@ -1340,8 +1340,8 @@ fi
 # pkg-config probe
 
 if ! has $pkg_config; then
-  echo warning: proceeding without "$pkg_config" >&2
-  pkg_config=/bin/false
+  echo "Error: pkg-config binary '$pkg_config' not found"
+  exit 1
 fi
 
 ##########################################
-- 
1.7.5.4

[Qemu-devel] [PATCH 3/8] fix compilation with stderr trace backend

[Stefan Hajnoczi]

From: Paolo Bonzini <pbonzini@redhat.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 trace-events |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/trace-events b/trace-events
index 829dc92..a31d9aa 100644
--- a/trace-events
+++ b/trace-events
@@ -455,7 +455,7 @@ milkymist_vgafb_memory_write(uint32_t addr, uint32_t value) "addr %08x value %08
 mipsnet_send(uint32_t size) "sending len=%u"
 mipsnet_receive(uint32_t size) "receiving len=%u"
 mipsnet_read(uint64_t addr, uint32_t val) "read addr=0x%" PRIx64 " val=0x%x"
-mipsnet_write(uint64_t addr, uint64_t val) "write addr=0x%" PRIx64 " val=0x%" PRIx64
+mipsnet_write(uint64_t addr, uint64_t val) "write addr=0x%" PRIx64 " val=0x%" PRIx64 ""
 mipsnet_irq(uint32_t isr, uint32_t intctl) "set irq to %d (%02x)"
 
 # xen-all.c
-- 
1.7.5.4

[Qemu-devel] [PATCH 4/8] Drop unneeded pthread.h inclusions

[Stefan Hajnoczi]

From: Jan Kiszka <jan.kiszka@siemens.com>

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/xen_nic.c       |    1 -
 hw/xics.c          |    2 --
 ui/spice-display.c |    2 --
 3 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/hw/xen_nic.c b/hw/xen_nic.c
index aeca8da..ef2a2d6 100644
--- a/hw/xen_nic.c
+++ b/hw/xen_nic.c
@@ -25,7 +25,6 @@
 #include <inttypes.h>
 #include <fcntl.h>
 #include <errno.h>
-#include <pthread.h>
 #include <sys/socket.h>
 #include <sys/ioctl.h>
 #include <sys/types.h>
diff --git a/hw/xics.c b/hw/xics.c
index 9bf82aa..80e064e 100644
--- a/hw/xics.c
+++ b/hw/xics.c
@@ -29,8 +29,6 @@
 #include "hw/spapr.h"
 #include "hw/xics.h"
 
-#include <pthread.h>
-
 /*
  * ICP: Presentation layer
  */
diff --git a/ui/spice-display.c b/ui/spice-display.c
index 3a92a12..6c302a3 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -15,8 +15,6 @@
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <pthread.h>
-
 #include "qemu-common.h"
 #include "qemu-spice.h"
 #include "qemu-timer.h"
-- 
1.7.5.4

[Qemu-devel] [PATCH 5/8] Silence make if nothing is to do for libcacard

[Stefan Hajnoczi]

From: Jan Kiszka <jan.kiszka@siemens.com>

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 libcacard/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/libcacard/Makefile b/libcacard/Makefile
index 81d9eb5..a145569 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -27,6 +27,8 @@ clean:
 	rm -Rf .libs
 
 all: vscclient
+# Dummy command so that make thinks it has done something
+	@true
 
 #########################################################################
 # Rules for building libcacard standalone library
-- 
1.7.5.4

[Qemu-devel] [PATCH 6/8] Abort on thread layer errors

[Stefan Hajnoczi]

From: Jan Kiszka <jan.kiszka@siemens.com>

Makes it easier to catch the bug in gdb as there is no need to set an
explicit breakpoint.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 qemu-thread-posix.c |    2 +-
 qemu-thread-win32.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
index 2bd02ef..ac3c0c9 100644
--- a/qemu-thread-posix.c
+++ b/qemu-thread-posix.c
@@ -22,7 +22,7 @@
 static void error_exit(int err, const char *msg)
 {
     fprintf(stderr, "qemu: %s: %s\n", msg, strerror(err));
-    exit(1);
+    abort();
 }
 
 void qemu_mutex_init(QemuMutex *mutex)
diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c
index a27332e..db8e744 100644
--- a/qemu-thread-win32.c
+++ b/qemu-thread-win32.c
@@ -24,7 +24,7 @@ static void error_exit(int err, const char *msg)
                   NULL, err, 0, (LPTSTR)&pstr, 2, NULL);
     fprintf(stderr, "qemu: %s: %s\n", msg, pstr);
     LocalFree(pstr);
-    exit(1);
+    abort();
 }
 
 void qemu_mutex_init(QemuMutex *mutex)
-- 
1.7.5.4

[Qemu-devel] [PATCH 7/8] Remove qemu_host_page_bits

[Stefan Hajnoczi]

From: Stefan Weil <weil@mail.berlios.de>

It was introduced with commit 54936004fddc52c321cb3f9a9a51140e782bed5d
as host_page_bits but never used.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 cpu-all.h |    1 -
 exec.c    |    4 ----
 2 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/cpu-all.h b/cpu-all.h
index f5c82cd..42a5fa0 100644
--- a/cpu-all.h
+++ b/cpu-all.h
@@ -290,7 +290,6 @@ extern unsigned long reserved_va;
 
 /* ??? These should be the larger of unsigned long and target_ulong.  */
 extern unsigned long qemu_real_host_page_size;
-extern unsigned long qemu_host_page_bits;
 extern unsigned long qemu_host_page_size;
 extern unsigned long qemu_host_page_mask;
 
diff --git a/exec.c b/exec.c
index c1e045d..1e6f732 100644
--- a/exec.c
+++ b/exec.c
@@ -183,7 +183,6 @@ typedef struct PageDesc {
 #define V_L1_SHIFT (L1_MAP_ADDR_SPACE_BITS - TARGET_PAGE_BITS - V_L1_BITS)
 
 unsigned long qemu_real_host_page_size;
-unsigned long qemu_host_page_bits;
 unsigned long qemu_host_page_size;
 unsigned long qemu_host_page_mask;
 
@@ -274,9 +273,6 @@ static void page_init(void)
         qemu_host_page_size = qemu_real_host_page_size;
     if (qemu_host_page_size < TARGET_PAGE_SIZE)
         qemu_host_page_size = TARGET_PAGE_SIZE;
-    qemu_host_page_bits = 0;
-    while ((1 << qemu_host_page_bits) < qemu_host_page_size)
-        qemu_host_page_bits++;
     qemu_host_page_mask = ~(qemu_host_page_size - 1);
 
 #if defined(CONFIG_BSD) && defined(CONFIG_USER_ONLY)
-- 
1.7.5.4

[Qemu-devel] [PATCH 8/8] use qemu_* ctype functions

[Stefan Hajnoczi]

From: Christoph Egger <Christoph.Egger@amd.com>

Fix "warning: array subscript has type 'char'" on NetBSD.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 cmd.c        |    2 +-
 ui/keymaps.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmd.c b/cmd.c
index ecca167..f77897e 100644
--- a/cmd.c
+++ b/cmd.c
@@ -389,7 +389,7 @@ cvtnum(
 	if (sp[1] != '\0')
 		return -1LL;
 
-	c = tolower(*sp);
+	c = qemu_tolower(*sp);
 	switch (c) {
 	default:
 		return i;
diff --git a/ui/keymaps.c b/ui/keymaps.c
index 81003bb..f54a114 100644
--- a/ui/keymaps.c
+++ b/ui/keymaps.c
@@ -146,7 +146,7 @@ static kbd_layout_t *parse_keyboard_layout(const name2keysym_t *table,
 		    if (rest && strstr(rest, "addupper")) {
 			char *c;
 			for (c = line; *c; c++)
-			    *c = toupper(*c);
+			    *c = qemu_toupper(*c);
 			keysym = get_keysym(table, line);
 			if (keysym)
 			    add_keysym(line, keysym, keycode | SCANCODE_SHIFT, k);
-- 
1.7.5.4

Re: [Qemu-devel] [PULL 0/8] Trivial patches for September 10 to 21 2011

[Anthony Liguori]

On 09/21/2011 05:25 AM, Stefan Hajnoczi wrote:
> The following changes since commit 27cdad67a1bc23b38c765b677ed8064bfb8d3e44:
>
>    Revert "alpha-softmmu: Disable for the 0.15 release branch." (2011-09-21 00:50:32 +0200)
>
> are available in the git repository at:
>    ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches

Pulled.  Thanks.

Regards,

Anthony Liguori

>
> Christoph Egger (1):
>        use qemu_* ctype functions
>
> Jan Kiszka (3):
>        Drop unneeded pthread.h inclusions
>        Silence make if nothing is to do for libcacard
>        Abort on thread layer errors
>
> Paolo Bonzini (1):
>        fix compilation with stderr trace backend
>
> Peter Maydell (1):
>        configure: Make missing pkg-config an error rather than a warning
>
> Stefan Weil (2):
>        target-i386: Remove data type CCTable
>        Remove qemu_host_page_bits
>
>   cmd.c                   |    2 +-
>   configure               |    4 ++--
>   cpu-all.h               |    1 -
>   exec.c                  |    4 ----
>   hw/xen_nic.c            |    1 -
>   hw/xics.c               |    2 --
>   libcacard/Makefile      |    2 ++
>   qemu-thread-posix.c     |    2 +-
>   qemu-thread-win32.c     |    2 +-
>   target-i386/cpu.h       |    5 -----
>   target-i386/translate.c |    5 -----
>   trace-events            |    2 +-
>   ui/keymaps.c            |    2 +-
>   ui/spice-display.c      |    2 --
>   14 files changed, 9 insertions(+), 27 deletions(-)
>