* [BUG] git-p4 can't cope with dollars in filenames
@ 2011-09-23 19:38 Luke Diamand
0 siblings, 0 replies; only message in thread
From: Luke Diamand @ 2011-09-23 19:38 UTC (permalink / raw)
To: Git List; +Cc: Pete Wyckoff
Hi!
If you have a dollar in a filename and attempt to submit it to Perforce
via git-p4 it fails.
e.g. this sequence:
% touch foo\$bar.c
% git commit -m 'whatever' foo\$bar.c
% git-p4 submit
....
....
Submit aborted -- fix problems then use 'p4 submit -c 3'.
The problem is all the places that use the git-p4 read_pipe() function,
which is a wrapper around os.popen(). popen() does shell expansion which
does hilarious things to files with dollars in their name.
You can have hours of fun and entertainment with this. Adding a file
called foo\`fortune\`.h is especially amusing.
I'm going to try to come up with a fix for this.
Luke
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-09-23 19:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 19:38 [BUG] git-p4 can't cope with dollars in filenames Luke Diamand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.