Re: RE: Stability report GPLPV 0.11.0.308

[Andreas Kinzler <ml-xen-devel@hfp.de>]

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

Hello James,

I did take a look at your commit 950 and I think there are 3 typos (see 
my patch). Anyway, I don't think that memory problems are causing the 
stability issues and (as some kind of "proof") I did not notice any 
increase in kernel memory usage during uptime of the VMs.

Actually I am not really sure if xennet is even the problem since in 
none of the crash scenarios there was something in the Windows event 
log. In my last test I was able to enter my password via VNC (it did not 
login though) - this should have written some entries to the security 
log which it did not. So I assume that xenvbd was dead too (killed by 
xennet) or is actually the real reason for the stability problems.

Regards Andreas

[-- Attachment #2: diff.patch --]
[-- Type: text/plain, Size: 1244 bytes --]

--- x\xennet6_rx.c	2011-09-22 13:47:46.000000000 +0200
+++ xennet6_rx.c	2011-09-23 22:39:47.892796400 +0200
@@ -50,8 +50,8 @@
   pb->mdl = IoAllocateMdl(pb->virtual, PAGE_SIZE, FALSE, FALSE, NULL);
   if (!pb->mdl)
   {
-    NdisFreeMemory(pb->virtual, sizeof(shared_buffer_t), 0);
-    NdisFreeMemory(pb, PAGE_SIZE, 0);
+    NdisFreeMemory(pb->virtual, PAGE_SIZE, 0);
+    NdisFreeMemory(pb, sizeof(shared_buffer_t), 0);
     return NULL;
   }
   pb->gref = (grant_ref_t)xi->vectors.GntTbl_GrantAccess(xi->vectors.context, 0,
@@ -59,8 +59,8 @@
   if (pb->gref == INVALID_GRANT_REF)
   {
     IoFreeMdl(pb->mdl);
-    NdisFreeMemory(pb->virtual, sizeof(shared_buffer_t), 0);
-    NdisFreeMemory(pb, PAGE_SIZE, 0);
+    NdisFreeMemory(pb->virtual, PAGE_SIZE, 0);
+    NdisFreeMemory(pb, sizeof(shared_buffer_t), 0);
     return NULL;
   }
   MmBuildMdlForNonPagedPool(pb->mdl);
@@ -85,8 +85,8 @@
     if (xi->rx_pb_free > RX_MAX_PB_FREELIST)
     {
       IoFreeMdl(pb->mdl);
-      NdisFreeMemory(pb->virtual, sizeof(shared_buffer_t), 0);
-      NdisFreeMemory(pb, PAGE_SIZE, 0);
+      NdisFreeMemory(pb->virtual, PAGE_SIZE, 0);
+      NdisFreeMemory(pb, sizeof(shared_buffer_t), 0);
       return;
     }
     pb->mdl->ByteCount = PAGE_SIZE;

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel