From: Jan Kiszka <jan.kiszka@siemens.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream
Date: Mon, 26 Sep 2011 19:23:23 +0200 [thread overview]
Message-ID: <4E80B50B.9000301@siemens.com> (raw)
In-Reply-To: <20110921080600.GA9847@stefanha-thinkpad.localdomain>
On 2011-09-21 10:06, Stefan Hajnoczi wrote:
> On Tue, Sep 20, 2011 at 06:49:49PM +0200, Jan Kiszka wrote:
>> Upstream's version is about to be signal-free and will stop handling
>> SIGUSR2 specially. So it's time to adopt its implementation, ie. switch
>> from signalfd to a pipe.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> This should help pulling upstream into qemu-kvm when "block: avoid
>> SIGUSR2" is merged. And will help merging further cleanups of this code
>> I'm working on.
>>
>> posix-aio-compat.c | 73 ++++++++++++++++++++++-----------------------------
>> 1 files changed, 32 insertions(+), 41 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> Perhaps qemu_eventfd() can be used in the future instead of an explicit
> pipe. Then Linux will do eventfd while other OSes will fall back to
> pipes.
Basically simpler code, or does this also have runtime benefits?
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-09-26 17:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 16:49 [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream Jan Kiszka
2011-09-21 8:06 ` Stefan Hajnoczi
2011-09-26 17:23 ` Jan Kiszka [this message]
2011-09-26 17:24 ` Avi Kivity
2011-09-26 18:09 ` Anthony Liguori
2011-09-27 9:00 ` Avi Kivity
2011-09-27 13:56 ` [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO Jan Kiszka
2011-09-27 14:07 ` Anthony Liguori
2011-09-27 14:11 ` Avi Kivity
2011-09-27 14:19 ` Anthony Liguori
2011-09-27 14:22 ` Avi Kivity
2011-09-27 14:22 ` Jan Kiszka
2011-09-27 14:38 ` Anthony Liguori
2011-09-27 14:29 ` Jan Kiszka
2011-09-27 14:34 ` Avi Kivity
2011-09-27 14:36 ` Jan Kiszka
2011-09-27 14:42 ` Avi Kivity
2011-09-27 14:45 ` Jan Kiszka
2011-09-27 14:48 ` Avi Kivity
2011-09-27 14:50 ` Jan Kiszka
2011-09-27 14:54 ` Avi Kivity
2011-09-27 14:57 ` Anthony Liguori
2011-09-27 14:59 ` Jan Kiszka
2011-09-27 14:36 ` Anthony Liguori
2011-09-27 14:41 ` Paolo Bonzini
2011-09-21 8:16 ` [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream Kevin Wolf
2011-09-26 16:56 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E80B50B.9000301@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mtosatti@redhat.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.