From: Jon Hunter <jon-hunter@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Mike Turquette <mturquette@ti.com>
Subject: Re: [PATCH v3 3/6] OMAP3+: use DPLL's round_rate when setting rate
Date: Wed, 28 Sep 2011 10:50:44 -0500 [thread overview]
Message-ID: <4E834254.9040802@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1109280059380.4399@utopia.booyaka.com>
Hi Paul,
On 9/28/2011 2:02, Paul Walmsley wrote:
> Hi,
>
> On Fri, 16 Sep 2011, Jon Hunter wrote:
>
>> From: Mike Turquette<mturquette@ti.com>
>>
>> omap3_noncore_dpll_set_rate uses omap2_dpll_round_rate explicitly. Instead
>> use the struct clk pointer's round_rate function to allow for DPLL's with
>> special needs.
>>
>> Also the rounded rate can differ from target rate, so to better reflect
>> reality set clk->rate equal to the rounded rate when setting DPLL frequency.
>> This avoids issues where the DPLL frequency is slightly different than what
>> debugfs clock tree reports using the old target rate.
>>
>> An example of both of these needs is DPLL_ABE on OMAP4 which can have a 4x
>> multiplier on top of the usual MN dividers depending on register settings.
>> This requires a special round_rate function that might yield a rate
>> different from the initial target.
>>
>> Signed-off-by: Mike Turquette<mturquette@ti.com>
>> Signed-off-by: Jon Hunter<jon-hunter@ti.com>
>
> The two separate changes in this patch have been separated out into two
> patches - both included below. Please let me know if you have any
> comments; otherwise, I'll queue for 3.2.
Yes, looks good to me. Thanks. Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/6] OMAP3+: use DPLL's round_rate when setting rate
Date: Wed, 28 Sep 2011 10:50:44 -0500 [thread overview]
Message-ID: <4E834254.9040802@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1109280059380.4399@utopia.booyaka.com>
Hi Paul,
On 9/28/2011 2:02, Paul Walmsley wrote:
> Hi,
>
> On Fri, 16 Sep 2011, Jon Hunter wrote:
>
>> From: Mike Turquette<mturquette@ti.com>
>>
>> omap3_noncore_dpll_set_rate uses omap2_dpll_round_rate explicitly. Instead
>> use the struct clk pointer's round_rate function to allow for DPLL's with
>> special needs.
>>
>> Also the rounded rate can differ from target rate, so to better reflect
>> reality set clk->rate equal to the rounded rate when setting DPLL frequency.
>> This avoids issues where the DPLL frequency is slightly different than what
>> debugfs clock tree reports using the old target rate.
>>
>> An example of both of these needs is DPLL_ABE on OMAP4 which can have a 4x
>> multiplier on top of the usual MN dividers depending on register settings.
>> This requires a special round_rate function that might yield a rate
>> different from the initial target.
>>
>> Signed-off-by: Mike Turquette<mturquette@ti.com>
>> Signed-off-by: Jon Hunter<jon-hunter@ti.com>
>
> The two separate changes in this patch have been separated out into two
> patches - both included below. Please let me know if you have any
> comments; otherwise, I'll queue for 3.2.
Yes, looks good to me. Thanks. Jon
next prev parent reply other threads:[~2011-09-28 15:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 17:48 [PATCH v3 3/6] OMAP3+: use DPLL's round_rate when setting rate Jon Hunter
2011-09-16 17:48 ` Jon Hunter
2011-09-28 7:02 ` Paul Walmsley
2011-09-28 7:02 ` Paul Walmsley
2011-09-28 15:50 ` Jon Hunter [this message]
2011-09-28 15:50 ` Jon Hunter
2011-09-28 22:39 ` Turquette, Mike
2011-09-28 22:39 ` Turquette, Mike
2011-09-30 0:51 ` [PATCH] OMAP2+: clock: use clock's recalc in DPLL handling Mike Turquette
2011-09-30 0:51 ` Mike Turquette
2011-09-30 1:26 ` Paul Walmsley
2011-09-30 1:26 ` Paul Walmsley
2011-09-30 1:33 ` Turquette, Mike
2011-09-30 1:33 ` Turquette, Mike
2011-10-07 7:07 ` Paul Walmsley
2011-10-07 7:07 ` Paul Walmsley
2011-10-07 19:32 ` Turquette, Mike
2011-10-07 19:32 ` Turquette, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E834254.9040802@ti.com \
--to=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@ti.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.