From: "Grégoire Sutre" <gregoire.sutre@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [patch] Make knetbsd pass the root device
Date: Thu, 29 Sep 2011 00:25:19 +0200 [thread overview]
Message-ID: <4E839ECF.8070509@gmail.com> (raw)
In-Reply-To: <4E838A23.4080107@gmail.com>
On 09/28/2011 10:57 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 28.09.2011 19:56, Grégoire Sutre wrote:
>> + grub_uint64_t buf[(GRUB_DISK_SECTOR_SIZE + 7) / 8];
> No need for + 7 since you know that GRUB_DISK_SECTOR_SIZE is divisible
> by 8. Other than this patch looks good. Go ahead
Thanks, committed.
> (I assume that you checked that it works well with NetBSD)
I made a number of tests, with various partitioning schemes,
mainly with NetBSD -current, but I also made a few with the
latest stable release.
Grégoire
prev parent reply other threads:[~2011-09-28 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 23:25 [patch] Make knetbsd pass the root device Grégoire Sutre
2011-09-21 9:13 ` Grégoire Sutre
2011-09-28 17:56 ` Grégoire Sutre
2011-09-28 20:57 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-09-28 22:25 ` Grégoire Sutre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E839ECF.8070509@gmail.com \
--to=gregoire.sutre@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.