From: Viresh Kumar <viresh.kumar@st.com>
To: Alim Akhtar <alim.akhtar@gmail.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC
Date: Thu, 29 Sep 2011 09:52:56 +0530 [thread overview]
Message-ID: <4E83F2A0.3090501@st.com> (raw)
In-Reply-To: <CAGOxZ535KHUp6An2br0scU9HvCmg4OsnfCj7hWYq4iy+OEpO2Q@mail.gmail.com>
On 9/28/2011 5:24 PM, Alim Akhtar wrote:
> I did Modified pl08x_cctl_bits(), but for some reason i reverted it back.
> what i was doing something like returning just __retbits__ instead of
> retbits |= tsize << PL080_CONTROL_TRANSFER_SIZE_SHIFT;
> and doing the below for the __non-s3c__ controllers in the
> pl08x_fill_lli_for_desc().
> cctl |= 1 << PL080_CONTROL_TRANSFER_SIZE_SHIFT;
> pl08x_fill_lli_for_desc(&bd, num_llis++, 1, cctl);
>
One way out would be:
Don't do retbits |= tsize << PL080_CONTROL_TRANSFER_SIZE_SHIFT in
pl08x_cctl_bits() and do this conditionally in pl08x_fill_lli_for_desc().
This needs adding tsize argument in fill_lli_**() routine and removing it
from cctl_bits().
Probably this is what you were mentioning.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC
Date: Thu, 29 Sep 2011 09:52:56 +0530 [thread overview]
Message-ID: <4E83F2A0.3090501@st.com> (raw)
In-Reply-To: <CAGOxZ535KHUp6An2br0scU9HvCmg4OsnfCj7hWYq4iy+OEpO2Q@mail.gmail.com>
On 9/28/2011 5:24 PM, Alim Akhtar wrote:
> I did Modified pl08x_cctl_bits(), but for some reason i reverted it back.
> what i was doing something like returning just __retbits__ instead of
> retbits |= tsize << PL080_CONTROL_TRANSFER_SIZE_SHIFT;
> and doing the below for the __non-s3c__ controllers in the
> pl08x_fill_lli_for_desc().
> cctl |= 1 << PL080_CONTROL_TRANSFER_SIZE_SHIFT;
> pl08x_fill_lli_for_desc(&bd, num_llis++, 1, cctl);
>
One way out would be:
Don't do retbits |= tsize << PL080_CONTROL_TRANSFER_SIZE_SHIFT in
pl08x_cctl_bits() and do this conditionally in pl08x_fill_lli_for_desc().
This needs adding tsize argument in fill_lli_**() routine and removing it
from cctl_bits().
Probably this is what you were mentioning.
--
viresh
next prev parent reply other threads:[~2011-09-29 4:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 5:50 [PATCH V2 0/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC Alim Akhtar
2011-09-28 5:50 ` Alim Akhtar
2011-09-28 5:50 ` [PATCH V2 1/1] " Alim Akhtar
2011-09-28 5:50 ` Alim Akhtar
2011-09-28 7:45 ` Viresh Kumar
2011-09-28 7:45 ` Viresh Kumar
2011-09-28 8:50 ` Alim Akhtar
2011-09-28 8:50 ` Alim Akhtar
2011-09-28 9:54 ` Viresh Kumar
2011-09-28 9:54 ` Viresh Kumar
2011-09-28 11:54 ` Alim Akhtar
2011-09-28 11:54 ` Alim Akhtar
2011-09-29 4:22 ` Viresh Kumar [this message]
2011-09-29 4:22 ` Viresh Kumar
2011-09-28 8:01 ` Linus Walleij
2011-09-28 8:01 ` Linus Walleij
2011-09-28 8:01 ` Linus Walleij
2011-09-28 8:59 ` Alim Akhtar
2011-09-28 8:59 ` Alim Akhtar
2011-12-07 23:43 ` [PATCH V2 0/1] " Linus Walleij
2011-12-07 23:43 ` Linus Walleij
2011-12-08 1:03 ` Alim Akhtar
2011-12-08 1:03 ` Alim Akhtar
2012-04-09 20:50 ` Linus Walleij
2012-04-09 20:50 ` Linus Walleij
2012-04-09 20:50 ` Linus Walleij
2012-05-28 4:41 ` Linus Walleij
2012-05-28 4:41 ` Linus Walleij
2012-05-28 7:36 ` Russell King - ARM Linux
2012-05-28 7:36 ` Russell King - ARM Linux
2012-05-29 9:23 ` Alim Akhtar
2012-05-29 9:23 ` Alim Akhtar
2012-07-09 20:47 ` Linus Walleij
2012-07-09 20:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E83F2A0.3090501@st.com \
--to=viresh.kumar@st.com \
--cc=alim.akhtar@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.