* [ath9k-devel] [RFC] ath9k_hw: set is_pciexpress true for AR9480
@ 2011-09-28 12:07 ` Mohammed Shafi Shajakhan
0 siblings, 0 replies; 6+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-09-28 12:07 UTC (permalink / raw)
To: ath9k-devel
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
the AR_SREV register does not seems to indicate it properly though the
other information like macVersion etc can be obtained properly
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/hw.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index f2de7ee..56ba6a8 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -284,7 +284,12 @@ static void ath9k_hw_read_revisions(struct ath_hw *ah)
ah->hw_version.macVersion =
(val & AR_SREV_VERSION2) >> AR_SREV_TYPE2_S;
ah->hw_version.macRev = MS(val, AR_SREV_REVISION2);
- ah->is_pciexpress = (val & AR_SREV_TYPE2_HOST_MODE) ? 0 : 1;
+
+ if (AR_SREV_9480(ah))
+ ah->is_pciexpress = true;
+ else
+ ah->is_pciexpress = (val &
+ AR_SREV_TYPE2_HOST_MODE) ? 0 : 1;
} else {
if (!AR_SREV_9100(ah))
ah->hw_version.macVersion = MS(val, AR_SREV_VERSION);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RFC] ath9k_hw: set is_pciexpress true for AR9480
@ 2011-09-28 12:07 ` Mohammed Shafi Shajakhan
0 siblings, 0 replies; 6+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-09-28 12:07 UTC (permalink / raw)
To: linux-wireless
Cc: John W. Linville, Jouni Malinen, Rodriguez Luis,
Balasubramanian senthilkumar, Vasanthakumar Thiagarajan,
Rajkumar Manoharan, Vivek Natarajan, ath9k-devel,
Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
the AR_SREV register does not seems to indicate it properly though the
other information like macVersion etc can be obtained properly
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/hw.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index f2de7ee..56ba6a8 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -284,7 +284,12 @@ static void ath9k_hw_read_revisions(struct ath_hw *ah)
ah->hw_version.macVersion =
(val & AR_SREV_VERSION2) >> AR_SREV_TYPE2_S;
ah->hw_version.macRev = MS(val, AR_SREV_REVISION2);
- ah->is_pciexpress = (val & AR_SREV_TYPE2_HOST_MODE) ? 0 : 1;
+
+ if (AR_SREV_9480(ah))
+ ah->is_pciexpress = true;
+ else
+ ah->is_pciexpress = (val &
+ AR_SREV_TYPE2_HOST_MODE) ? 0 : 1;
} else {
if (!AR_SREV_9100(ah))
ah->hw_version.macVersion = MS(val, AR_SREV_VERSION);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [ath9k-devel] [RFC] ath9k_hw: set is_pciexpress true for AR9480
2011-09-28 12:07 ` Mohammed Shafi Shajakhan
@ 2011-09-28 23:23 ` Felix Fietkau
-1 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2011-09-28 23:23 UTC (permalink / raw)
To: ath9k-devel
On 2011-09-28 2:07 PM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>
> the AR_SREV register does not seems to indicate it properly though the
> other information like macVersion etc can be obtained properly
How about using AR_SREV_9300_20_OR_LATER(ah) instead to make sure that
this works properly for future chips as well?
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] ath9k_hw: set is_pciexpress true for AR9480
@ 2011-09-28 23:23 ` Felix Fietkau
0 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2011-09-28 23:23 UTC (permalink / raw)
To: Mohammed Shafi Shajakhan
Cc: linux-wireless, John W. Linville, Jouni Malinen, Rodriguez Luis,
Balasubramanian senthilkumar, Vasanthakumar Thiagarajan,
Rajkumar Manoharan, Vivek Natarajan, ath9k-devel
On 2011-09-28 2:07 PM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>
> the AR_SREV register does not seems to indicate it properly though the
> other information like macVersion etc can be obtained properly
How about using AR_SREV_9300_20_OR_LATER(ah) instead to make sure that
this works properly for future chips as well?
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ath9k-devel] [RFC] ath9k_hw: set is_pciexpress true for AR9480
2011-09-28 23:23 ` Felix Fietkau
@ 2011-09-29 5:17 ` mohammed
-1 siblings, 0 replies; 6+ messages in thread
From: mohammed @ 2011-09-29 5:17 UTC (permalink / raw)
To: ath9k-devel
Hi Felix,
On Thursday 29 September 2011 04:53 AM, Felix Fietkau wrote:
> On 2011-09-28 2:07 PM, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> the AR_SREV register does not seems to indicate it properly though the
>> other information like macVersion etc can be obtained properly
> How about using AR_SREV_9300_20_OR_LATER(ah) instead to make sure that
> this works properly for future chips as well?
this seems to be a problem specifically for AR9480 and this problem does
not seems to be observed in AR9485. but its needed as if is_pciexpress
is false ASPM won't be initialized
>
> - Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] ath9k_hw: set is_pciexpress true for AR9480
@ 2011-09-29 5:17 ` mohammed
0 siblings, 0 replies; 6+ messages in thread
From: mohammed @ 2011-09-29 5:17 UTC (permalink / raw)
To: Felix Fietkau
Cc: linux-wireless, John W. Linville, Jouni Malinen, Rodriguez Luis,
Balasubramanian senthilkumar, Vasanthakumar Thiagarajan,
Rajkumar Manoharan, Vivek Natarajan, ath9k-devel
Hi Felix,
On Thursday 29 September 2011 04:53 AM, Felix Fietkau wrote:
> On 2011-09-28 2:07 PM, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> the AR_SREV register does not seems to indicate it properly though the
>> other information like macVersion etc can be obtained properly
> How about using AR_SREV_9300_20_OR_LATER(ah) instead to make sure that
> this works properly for future chips as well?
this seems to be a problem specifically for AR9480 and this problem does
not seems to be observed in AR9485. but its needed as if is_pciexpress
is false ASPM won't be initialized
>
> - Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-09-29 5:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-28 12:07 [ath9k-devel] [RFC] ath9k_hw: set is_pciexpress true for AR9480 Mohammed Shafi Shajakhan
2011-09-28 12:07 ` Mohammed Shafi Shajakhan
2011-09-28 23:23 ` [ath9k-devel] " Felix Fietkau
2011-09-28 23:23 ` Felix Fietkau
2011-09-29 5:17 ` [ath9k-devel] " mohammed
2011-09-29 5:17 ` mohammed
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.