From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH 2/2] Disable unsupported grub_util_get_fd_sectors in geli on MINGW32
Date: Thu, 29 Sep 2011 10:42:08 +0200 [thread overview]
Message-ID: <4E842F60.1020007@gmail.com> (raw)
In-Reply-To: <4E7A574D.5000606@dell.com>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
Rejected. Better a compilation error than an eratic behaviour on runtime.
On 21.09.2011 23:29, Mario Limonciello wrote:
> === modified file 'ChangeLog'
> --- ChangeLog 2011-09-21 21:00:59 +0000
> +++ ChangeLog 2011-09-21 21:18:21 +0000
> @@ -6,6 +6,8 @@
> Windows CreateFile calls.
> * Undefine GRUB_UTIL in grub-core/lib/crypto.c for MINGW32 as
> termios is not supported.
> + * Disable unsupported grub_util_get_fd_sectors in geli on
> + MINGW32.
>
> 2011-09-17 Grégoire Sutre <gregoire.sutre@gmail.com>
>
>
> === modified file 'grub-core/disk/geli.c'
> --- grub-core/disk/geli.c 2011-04-25 12:52:07 +0000
> +++ grub-core/disk/geli.c 2011-09-21 21:18:21 +0000
> @@ -189,8 +189,10 @@
> if (fd < 0)
> return NULL;
>
> +#if !defined(__MINGW32__)
> s = grub_util_get_fd_sectors (fd, &log_secsize);
> grub_util_fd_seek (fd, dev, (s << log_secsize) - 512);
> +#endif
>
> uuid = xmalloc (GRUB_MD_SHA256->mdlen * 2 + 1);
> if (grub_util_fd_read (fd, (void *) &hdr, 512) < 0)
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2011-09-29 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 21:29 [PATCH 2/2] Disable unsupported grub_util_get_fd_sectors in geli on MINGW32 Mario Limonciello
2011-09-21 22:08 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-09-29 8:42 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E842F60.1020007@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.