From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH 2/2] Disable unsupported grub_util_get_fd_sectors in geli on MINGW32
Date: Thu, 22 Sep 2011 00:08:12 +0200 [thread overview]
Message-ID: <4E7A604C.3090308@gmail.com> (raw)
In-Reply-To: <4E7A574D.5000606@dell.com>
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On 21.09.2011 23:29, Mario Limonciello wrote:
> +#if !defined(__MINGW32__)
> s = grub_util_get_fd_sectors (fd, &log_secsize);
> grub_util_fd_seek (fd, dev, (s << log_secsize) - 512);
> +#endif
This would make GRUB behave erratically if this code is ever reached
which is always a bad thing. While doing something like
#if defined (GRUB_UTIL) && ! defined (__MINGW32__)
on whole function is a cheap and functionality-reducing way to port,
correct way is to add a windows equivalent of this call (getting
disk/file size)
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2011-09-21 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 21:29 [PATCH 2/2] Disable unsupported grub_util_get_fd_sectors in geli on MINGW32 Mario Limonciello
2011-09-21 22:08 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2011-09-29 8:42 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7A604C.3090308@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.