From: Jaehoon Chung <jh80.chung@samsung.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
kyungmin.park@samsung.com, Will Newton <will.newton@imgtec.com>
Subject: Re: [PATCH] mmc: dw_mmc: add write/read function for DATA register
Date: Fri, 30 Sep 2011 19:01:09 +0900 [thread overview]
Message-ID: <4E859365.8060601@samsung.com> (raw)
In-Reply-To: <4E8584EA.5000900@imgtec.com>
Hi James.
> Can I suggest that instead of having 6 new macros with offset parameters
> from the reg parameter (after all, the caller can just add the offset to
> the reg argument just as easily), you simply store the data register
> offset (what is currently DATA+host->data_offset) instead of
> host->data_offset, and use that instead of DATA. That would be simpler
> and more readable.
Sure..i understood your suggestion. But i think that need check the
version-id. i will also consider more..:)
>
> DATA should probably be defined as the most up to date value, and define
> another one for pre-240A versions.
Right. i wonder why changed the DATA register :(
Best Regards,
Jaehoon Chung
next prev parent reply other threads:[~2011-09-30 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 8:37 [PATCH] mmc: dw_mmc: add write/read function for DATA register Jaehoon Chung
2011-09-30 8:59 ` James Hogan
2011-09-30 10:01 ` Jaehoon Chung [this message]
2011-09-30 10:10 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E859365.8060601@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.