Re: [PATCH] mmc: dw_mmc: add write/read function for DATA register

[James Hogan <james.hogan@imgtec.com>]

Hi

On 09/30/2011 11:01 AM, Jaehoon Chung wrote:
> Hi James.
> 
>> Can I suggest that instead of having 6 new macros with offset parameters
>> from the reg parameter (after all, the caller can just add the offset to
>> the reg argument just as easily), you simply store the data register
>> offset (what is currently DATA+host->data_offset) instead of
>> host->data_offset, and use that instead of DATA. That would be simpler
>> and more readable.
> 
> 
> Sure..i understood your suggestion. But i think that need check the
> version-id. i will also consider more..:)

Yes, I mean where you currently set host->data_offset depending on the
version id, set it to e.g. DATA or DATA_PRE240A (maybe DATA_LEGACY)
depending on the version id. Then use host->data_offset instead of DATA
everywhere else.

> 
>>
>> DATA should probably be defined as the most up to date value, and define
>> another one for pre-240A versions.
> 
> 
> Right. i wonder why changed the DATA register :(

Indeed, hopefully now they'll have twice as much space for normal
registers and won't have to change it again. I'm just happy they didn't
move the version id register!

Cheers
James

> 
> Best Regards,
> Jaehoon Chung