All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Chris Friesen <chris.friesen@genband.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [BUG] need to export variables in config.mak
Date: Fri, 30 Sep 2011 19:12:10 +0200	[thread overview]
Message-ID: <4E85F86A.7070305@siemens.com> (raw)
In-Reply-To: <4E85F741.2050100@genband.com>

On 2011-09-30 19:07, Chris Friesen wrote:
> We've been playing a bit with kvm-kmod-3.0b.  We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have any effect.
> 
> I think something like the following patch is required.

If you can confirm that they have the right effect and put a signed-off
+ description to the patch, I'll merge it.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Chris Friesen <chris.friesen@genband.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [BUG] need to export variables in config.mak
Date: Fri, 30 Sep 2011 19:12:10 +0200	[thread overview]
Message-ID: <4E85F86A.7070305@siemens.com> (raw)
In-Reply-To: <4E85F741.2050100@genband.com>

On 2011-09-30 19:07, Chris Friesen wrote:
> We've been playing a bit with kvm-kmod-3.0b.  We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have any effect.
> 
> I think something like the following patch is required.

If you can confirm that they have the right effect and put a signed-off
+ description to the patch, I'll merge it.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2011-09-30 17:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30 17:07 [BUG] need to export variables in config.mak Chris Friesen
2011-09-30 17:07 ` [Qemu-devel] " Chris Friesen
2011-09-30 17:12 ` Jan Kiszka [this message]
2011-09-30 17:12   ` Jan Kiszka
2011-09-30 17:40   ` [PATCH] " Chris Friesen
2011-09-30 17:40     ` [Qemu-devel] " Chris Friesen
2011-10-03  7:57     ` Jan Kiszka
2011-10-03  7:57       ` [Qemu-devel] " Jan Kiszka
2011-09-30 17:52 ` [Qemu-devel] [BUG] " Richard Henderson
2011-09-30 17:52   ` Richard Henderson
2011-09-30 18:00   ` Alexander Graf
2011-09-30 18:14   ` Chris Friesen
2011-09-30 18:14     ` [Qemu-devel] " Chris Friesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E85F86A.7070305@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=avi@redhat.com \
    --cc=chris.friesen@genband.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.