From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rientjes@google.com, James.Bottomley@HansenPartnership.com
Subject: Re: [RFC][PATCH 2/4] break out unit selection from string_get_size()
Date: Fri, 30 Sep 2011 11:54:19 -0700 [thread overview]
Message-ID: <4E86105B.3070901@zytor.com> (raw)
In-Reply-To: <20110930180242.D89C1A59@kernel>
On 09/30/2011 11:02 AM, Dave Hansen wrote:
> string_get_size() can really only print things in a single
> format. You're always stuck with a space, and it will
> always zero-pad the decimal places:
>
> 4.00 KiB
> 40.0 KiB
> 400 KiB
>
> Printing page sizes in decimal KiB does not make much sense
> since they are always nice powers of two. But,
> string_get_size() does have some nice code for selecting
> the right units and doing the division.
>
> This breaks that nice code out so that we can reuse it.
> find_size_units() is a bit of a funky function since it has
> so many outputs. I don't think it's _too_ crazy though.
>
> Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
For powers of two, wouldn't it make a lot more sense to just do ilog2()
to get the power of two and then the moral equivalent of:
sprintf("%u %s", 1 << (pw2 % 10), units_str[pw2 / 10]);
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rientjes@google.com, James.Bottomley@HansenPartnership.com
Subject: Re: [RFC][PATCH 2/4] break out unit selection from string_get_size()
Date: Fri, 30 Sep 2011 11:54:19 -0700 [thread overview]
Message-ID: <4E86105B.3070901@zytor.com> (raw)
In-Reply-To: <20110930180242.D89C1A59@kernel>
On 09/30/2011 11:02 AM, Dave Hansen wrote:
> string_get_size() can really only print things in a single
> format. You're always stuck with a space, and it will
> always zero-pad the decimal places:
>
> 4.00 KiB
> 40.0 KiB
> 400 KiB
>
> Printing page sizes in decimal KiB does not make much sense
> since they are always nice powers of two. But,
> string_get_size() does have some nice code for selecting
> the right units and doing the division.
>
> This breaks that nice code out so that we can reuse it.
> find_size_units() is a bit of a funky function since it has
> so many outputs. I don't think it's _too_ crazy though.
>
> Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
For powers of two, wouldn't it make a lot more sense to just do ilog2()
to get the power of two and then the moral equivalent of:
sprintf("%u %s", 1 << (pw2 % 10), units_str[pw2 / 10]);
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-30 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 18:02 [RFC][PATCH 1/4] break up string_get_size() Dave Hansen
2011-09-30 18:02 ` Dave Hansen
2011-09-30 18:02 ` [RFC][PATCH 2/4] break out unit selection from string_get_size() Dave Hansen
2011-09-30 18:02 ` Dave Hansen
2011-09-30 18:54 ` H. Peter Anvin [this message]
2011-09-30 18:54 ` H. Peter Anvin
2011-09-30 18:02 ` [RFC][PATCH 3/4] add seq_print_size() function Dave Hansen
2011-09-30 18:02 ` Dave Hansen
2011-09-30 18:02 ` [RFC][PATCH 4/4] show page size in /proc/$pid/numa_maps Dave Hansen
2011-09-30 18:02 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E86105B.3070901@zytor.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.