From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused
Date: Tue, 04 Oct 2011 16:09:03 +0200 [thread overview]
Message-ID: <4E8B137F.6060707@redhat.com> (raw)
In-Reply-To: <20111004104914.5ab8a3df@doriath>
On 10/04/2011 03:49 PM, Luiz Capitulino wrote:
> There's a semantic change which I'm not completely sure it won't generate
> unexpected side-effects: today vm_stop() will only carry any action if the
> machine is running, otherwise it's no-op. This patch changes that.
More or less, yes. I tried to limit the semantic change by not running
notifiers, which again could be better or worse.
I don't think adding a new transition is a good solution, because you'll
have to add a transition from PAUSED to anything that uses runstate_set
instead of vm_stop.
However, you could change all vm_stop() to vm_stop(RSTATE_PAUSED)
followed by runstate_set(), adjust the transition table consequently and
possibly drop the argument to vm_stop. I tried to get the smallest
patch, but I did need to follow-up with changes to the transition table.
In any case, can I assume this to be in your hands now? :)
Paolo
next prev parent reply other threads:[~2011-10-04 14:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 12:04 [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused Paolo Bonzini
2011-10-04 13:49 ` Luiz Capitulino
2011-10-04 14:09 ` Paolo Bonzini [this message]
2011-10-04 14:30 ` Luiz Capitulino
2011-10-05 14:37 ` Luiz Capitulino
2011-10-05 15:43 ` Avi Kivity
2011-10-05 15:44 ` Avi Kivity
2011-10-05 16:31 ` Jan Kiszka
2011-10-05 16:37 ` Avi Kivity
2011-10-05 16:49 ` Jan Kiszka
2011-10-05 17:12 ` Avi Kivity
2011-10-05 18:02 ` Jan Kiszka
2011-10-06 14:27 ` Avi Kivity
2011-10-06 15:08 ` Jan Kiszka
2011-10-05 17:02 ` Luiz Capitulino
2011-10-05 17:23 ` Avi Kivity
2011-10-05 17:39 ` Luiz Capitulino
2011-10-05 18:02 ` Avi Kivity
2011-10-05 18:49 ` Luiz Capitulino
2011-10-05 18:50 ` Luiz Capitulino
2011-10-06 11:14 ` Paolo Bonzini
2011-10-10 18:49 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8B137F.6060707@redhat.com \
--to=pbonzini@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.